From: James Hogan <james.hogan@mips.com>
To: <gregkh@linuxfoundation.org>
Cc: <clabbe.montjoie@gmail.com>, <ralf@linux-mips.org>,
<stable@vger.kernel.org>, <stable-commits@vger.kernel.org>
Subject: Re: Patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN" has been added to the 4.15-stable tree
Date: Tue, 20 Feb 2018 15:32:44 +0000 [thread overview]
Message-ID: <20180220153244.GD29460@jhogan-linux.mipstec.com> (raw)
In-Reply-To: <151912500624766@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 3587 bytes --]
Hi Greg,
On Tue, Feb 20, 2018 at 12:10:06PM +0100, gregkh@linuxfoundation.org wrote:
>
> This is a note to let you know that I've just added the patch titled
>
> MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
>
> to the 4.15-stable tree which can be found at:
> http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
>
> The filename of the patch is:
> mips-fix-typo-big_endian-to-cpu_big_endian.patch
> and it can be found in the queue-4.15 subdirectory.
>
> If you, or anyone else, feels it should not be added to the stable tree,
> please let <stable@vger.kernel.org> know about it.
FYI this will introduce the following harmless kconfig warnings which
are fixed by commit ec897569ad7d ("usb: Move USB_UHCI_BIG_ENDIAN_* out
of USB_SUPPORT"):
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_MMIO which has unmet direct dependencies (USB_SUPPORT && USB)
warning: (MIPS_GENERIC) selects USB_UHCI_BIG_ENDIAN_DESC which has unmet direct dependencies (USB_SUPPORT && USB)
If anybody cares about such warnings, that patch could be applied also.
Thanks
James
>
>
> From 2e6522c565522a2e18409c315c49d78c8b74807b Mon Sep 17 00:00:00 2001
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
> Date: Wed, 17 Jan 2018 19:56:38 +0100
> Subject: MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN
>
> From: Corentin Labbe <clabbe.montjoie@gmail.com>
>
> commit 2e6522c565522a2e18409c315c49d78c8b74807b upstream.
>
> MIPS_GENERIC selects some options conditional on BIG_ENDIAN which does
> not exist.
>
> Replace BIG_ENDIAN with CPU_BIG_ENDIAN which is the correct kconfig
> name. Note that BMIPS_GENERIC does the same which confirms that this
> patch is needed.
>
> Fixes: eed0eabd12ef0 ("MIPS: generic: Introduce generic DT-based board support")
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> Reviewed-by: James Hogan <jhogan@kernel.org>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: linux-mips@linux-mips.org
> Cc: <stable@vger.kernel.org> # 4.9+
> Patchwork: https://patchwork.linux-mips.org/patch/18495/
> [jhogan@kernel.org: Clean up commit message]
> Signed-off-by: James Hogan <jhogan@kernel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> ---
> arch/mips/Kconfig | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -119,12 +119,12 @@ config MIPS_GENERIC
> select SYS_SUPPORTS_MULTITHREADING
> select SYS_SUPPORTS_RELOCATABLE
> select SYS_SUPPORTS_SMARTMIPS
> - select USB_EHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_EHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_OHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_DESC if BIG_ENDIAN
> - select USB_UHCI_BIG_ENDIAN_MMIO if BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_EHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_OHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_DESC if CPU_BIG_ENDIAN
> + select USB_UHCI_BIG_ENDIAN_MMIO if CPU_BIG_ENDIAN
> select USE_OF
> help
> Select this to build a kernel which aims to support multiple boards,
>
>
> Patches currently in stable-queue which might be from clabbe.montjoie@gmail.com are
>
> queue-4.15/mips-fix-typo-big_endian-to-cpu_big_endian.patch
> queue-4.15/crypto-sun4i_ss_prng-fix-return-value-of-sun4i_ss_prng_generate.patch
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-20 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-20 11:10 Patch "MIPS: Fix typo BIG_ENDIAN to CPU_BIG_ENDIAN" has been added to the 4.15-stable tree gregkh
2018-02-20 15:32 ` James Hogan [this message]
2018-02-20 15:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180220153244.GD29460@jhogan-linux.mipstec.com \
--to=james.hogan@mips.com \
--cc=clabbe.montjoie@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ralf@linux-mips.org \
--cc=stable-commits@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).