RE: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than globally

Mario.Limonciello
2018-02-27T15:01:28Z

> From: Limonciello, Mario
> Sent: Thursday, February 15, 2018 8:50 AM
> To: 'Greg KH' <gregkh@linuxfoundation.org>
> Cc: stable@vger.kernel.org; andriy.shevchenko@linux.intel.com
> Subject: RE: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather than
> globally
>
> > -----Original Message-----
> > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > Sent: Thursday, February 15, 2018 8:28 AM
> > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > Cc: stable@vger.kernel.org; andriy.shevchenko@linux.intel.com
> > Subject: Re: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather
> than
> > globally
> >
> > On Tue, Feb 13, 2018 at 07:54:10PM +0000, Mario.Limonciello@dell.com wrote:
> > > > -----Original Message-----
> > > > From: Greg KH [mailto:gregkh@linuxfoundation.org]
> > > > Sent: Tuesday, February 13, 2018 1:52 PM
> > > > To: Limonciello, Mario <Mario_Limonciello@Dell.com>
> > > > Cc: linux-stable <stable@vger.kernel.org>; Andy Shevchenko
> > > > <andriy.shevchenko@linux.intel.com>
> > > > Subject: Re: [PATCH] platform/x86: dell-laptop: Allocate buffer on heap rather
> > than
> > > > globally
> > > >
> > > > On Tue, Feb 13, 2018 at 01:39:19PM -0600, Mario Limonciello wrote:
> > > > > There is no longer a need for the buffer to be defined in
> > > > > first 4GB physical address space.
> > > > >
> > > > > Furthermore there may be race conditions with multiple different functions
> > > > > working on a module wide buffer causing incorrect results.
> > > > >
> > > > > This commit has been backported from:
> > > > > commit 9862b43624 upstream
> > > > >
> > > > > Fixes: 549b4930f057658dc50d8010e66219233119a4d8
> > > > > Suggested-by: Pali Rohar <pali.rohar@gmail.com>
> > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
> > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > > > ---
> > > > > drivers/platform/x86/dell-laptop.c | 188 ++++++++++++++++++++--------------
> --
> > -
> > > > > 1 file changed, 103 insertions(+), 85 deletions(-)
> > > >
> > > > Why is this a stable patch? What bug does it fix?
> > > >
> > > > confused,
> > > >
> > > > greg k-h
> > >
> > > Greg,
> > >
> > > I realized I forgot to send this 2 weeks ago when you said a clean backport
> > > didn't work. This was a follow up from a race condition that was seen in
> > > the wild and submitted to platform-x86.
> >
> > Ok, what kernel tree(s) do you want it applied to? I need a hint please :)
> >
> > thanks,
> >
> > greg k-h
>
> 4.15.y please.
>
> Thank you,

Hi Greg,

I just wanted to follow up on this one because I noticed it's not in 4.15.y still
And there are some bug traffics about problems.

There's also another patch that was CC'ed to stable that came after it that
should be going to 4.15.y.

I can resubmit it with those bug URLs and squash that patch if it's helpful to
you.

Thanks