From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53636 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933579AbeCEKmG (ORCPT ); Mon, 5 Mar 2018 05:42:06 -0500 Date: Mon, 5 Mar 2018 10:42:03 +0000 From: Mark Brown To: Sasha Levin Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Javier Martinez Canillas Subject: Re: [PATCH AUTOSEL for 4.9 111/219] ASoc: rt5645: Add OF device ID table Message-ID: <20180305104203.GD8588@sirena.org.uk> References: <20180303222716.26640-1-alexander.levin@microsoft.com> <20180303222716.26640-111-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tEFtbjk+mNEviIIX" Content-Disposition: inline In-Reply-To: <20180303222716.26640-111-alexander.levin@microsoft.com> Sender: stable-owner@vger.kernel.org List-ID: --tEFtbjk+mNEviIIX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Mar 03, 2018 at 10:29:00PM +0000, Sasha Levin wrote: > From: Javier Martinez Canillas >=20 > [ Upstream commit 9ba2da5f5d18daaa365ab5426b05e16f1d114786 ] >=20 > The driver doesn't have a struct of_device_id table but supported devices > are registered via Device Trees. This is working on the assumption that a > I2C device registered via OF will always match a legacy I2C device ID and > that the MODALIAS reported will always be of the form i2c:. >=20 > But this could change in the future so the correct approach is to have an > OF device ID table if the devices are registered via OF. As the commit message itself says this is not fixing anything, it's defence against future changes. --tEFtbjk+mNEviIIX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqdHvoACgkQJNaLcl1U h9C/wgf8C46FVefXMmhXCA2bYLBCvD7d7nNL7ohQL8xEiO4WSDrlqT145Vg85EEu OQddwHl3OM0vHgO9i/L7tkjh6ujKYFT7xkIQdWxX/q4DP6kpcQIh6pvtG6T2/dMh 5NZFVrXMRSd38kNHwusrN+d6S+qOPbpI8w6R6JO/aSqSSplOALO62ZMeqrlRBEHk hUJglN1Kv7sug/ofzf0EV3TRhEhykYkYLIaKN32Aksh1qnhydQJAZb3iCl022D0o Yty9U5LX29JPFTSgcVxmZw8NUQ0oZkxwM1jyKtB7N33EznPpGm9WC804bNqG4Yju xspDdDCfaArGd3BK8/Tg1O1kBI2bhw== =9t9S -----END PGP SIGNATURE----- --tEFtbjk+mNEviIIX--