From: Greg KH <gregkh@linuxfoundation.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: stable@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions
Date: Wed, 7 Mar 2018 09:27:21 -0800 [thread overview]
Message-ID: <20180307172721.GG7097@kroah.com> (raw)
In-Reply-To: <20180305193215.23008-1-sagi@grimberg.me>
On Mon, Mar 05, 2018 at 09:32:15PM +0200, Sagi Grimberg wrote:
> The entire completions suppress mechanism is currently broken because the
> HCA might retry a send operation (due to dropped ack) after the nvme
> transaction has completed.
>
> In order to handle this, we signal all send completions and introduce a
> separate done handler for async events as they will be handled differently
> (as they don't include in-capsule data by definition).
>
> Cc: <stable@vger.kernel.org> # v4.14+
> Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/rdma.c | 54 +++++++++++++-----------------------------------
> 1 file changed, 14 insertions(+), 40 deletions(-)
What is the git commit id for this patch in Linus's tree?
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-07 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 19:32 [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions Sagi Grimberg
2018-03-07 17:27 ` Greg KH [this message]
2018-03-07 17:41 ` Keith Busch
2018-03-07 19:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307172721.GG7097@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox