From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:41402 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933596AbeCGR1W (ORCPT ); Wed, 7 Mar 2018 12:27:22 -0500 Date: Wed, 7 Mar 2018 09:27:21 -0800 From: Greg KH To: Sagi Grimberg Cc: stable@vger.kernel.org, linux-nvme@lists.infradead.org Subject: Re: [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions Message-ID: <20180307172721.GG7097@kroah.com> References: <20180305193215.23008-1-sagi@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180305193215.23008-1-sagi@grimberg.me> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 05, 2018 at 09:32:15PM +0200, Sagi Grimberg wrote: > The entire completions suppress mechanism is currently broken because the > HCA might retry a send operation (due to dropped ack) after the nvme > transaction has completed. > > In order to handle this, we signal all send completions and introduce a > separate done handler for async events as they will be handled differently > (as they don't include in-capsule data by definition). > > Cc: # v4.14+ > Signed-off-by: Sagi Grimberg > Reviewed-by: Max Gurtovoy > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/rdma.c | 54 +++++++++++++----------------------------------- > 1 file changed, 14 insertions(+), 40 deletions(-) What is the git commit id for this patch in Linus's tree? thanks, greg k-h