From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga07.intel.com ([134.134.136.100]:56611 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932905AbeCGRlX (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 7 Mar 2018 12:41:23 -0500
Date: Wed, 7 Mar 2018 10:41:22 -0700
From: Keith Busch <keith.busch@intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sagi Grimberg <sagi@grimberg.me>, linux-nvme@lists.infradead.org,
        stable@vger.kernel.org
Subject: Re: [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions
Message-ID: <20180307174121.GB3766@localhost.localdomain>
References: <20180305193215.23008-1-sagi@grimberg.me>
 <20180307172721.GG7097@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180307172721.GG7097@kroah.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Wed, Mar 07, 2018 at 09:27:21AM -0800, Greg KH wrote:
> On Mon, Mar 05, 2018 at 09:32:15PM +0200, Sagi Grimberg wrote:
> > The entire completions suppress mechanism is currently broken because the
> > HCA might retry a send operation (due to dropped ack) after the nvme
> > transaction has completed.
> > 
> > In order to handle this, we signal all send completions and introduce a
> > separate done handler for async events as they will be handled differently
> > (as they don't include in-capsule data by definition).
> > 
> > Cc: <stable@vger.kernel.org> # v4.14+
> > Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
> > Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> >  drivers/nvme/host/rdma.c | 54 +++++++++++++-----------------------------------
> >  1 file changed, 14 insertions(+), 40 deletions(-)
> 
> What is the git commit id for this patch in Linus's tree?

Commit b4b591c87f2b0f4ebaf3a68d4f13873b241aa584 upstream