From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:56580 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754714AbeCGTDC (ORCPT ); Wed, 7 Mar 2018 14:03:02 -0500 Date: Wed, 7 Mar 2018 11:03:04 -0800 From: Greg KH To: Keith Busch Cc: Sagi Grimberg , linux-nvme@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH stable 4.14.y] nvme-rdma: don't suppress send completions Message-ID: <20180307190303.GA18426@kroah.com> References: <20180305193215.23008-1-sagi@grimberg.me> <20180307172721.GG7097@kroah.com> <20180307174121.GB3766@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180307174121.GB3766@localhost.localdomain> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Mar 07, 2018 at 10:41:22AM -0700, Keith Busch wrote: > On Wed, Mar 07, 2018 at 09:27:21AM -0800, Greg KH wrote: > > On Mon, Mar 05, 2018 at 09:32:15PM +0200, Sagi Grimberg wrote: > > > The entire completions suppress mechanism is currently broken because the > > > HCA might retry a send operation (due to dropped ack) after the nvme > > > transaction has completed. > > > > > > In order to handle this, we signal all send completions and introduce a > > > separate done handler for async events as they will be handled differently > > > (as they don't include in-capsule data by definition). > > > > > > Cc: # v4.14+ > > > Signed-off-by: Sagi Grimberg > > > Reviewed-by: Max Gurtovoy > > > Signed-off-by: Christoph Hellwig > > > --- > > > drivers/nvme/host/rdma.c | 54 +++++++++++++----------------------------------- > > > 1 file changed, 14 insertions(+), 40 deletions(-) > > > > What is the git commit id for this patch in Linus's tree? > > Commit b4b591c87f2b0f4ebaf3a68d4f13873b241aa584 upstream thanks, now queued up. greg k-h