From: Keith Busch <keith.busch@intel.com>
To: Sitsofe Wheeler <sitsofe@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>,
sagi@grimberg.me, Potnuri Bharat Teja <bharat@chelsio.com>,
Karel Zak <kzak@redhat.com>, stable <stable@vger.kernel.org>
Subject: Re: [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers"
Date: Wed, 7 Mar 2018 13:37:41 -0700 [thread overview]
Message-ID: <20180307203741.GC3766@localhost.localdomain> (raw)
In-Reply-To: <CALjAwxgic8ACMRW_56W+BVnikUK+FzNmp-UMJ3qNYmxPZ3idsg@mail.gmail.com>
On Wed, Mar 07, 2018 at 05:47:34PM +0000, Sitsofe Wheeler wrote:
> The only thing that concerns me is where do the stats live? Over in
> https://github.com/axboe/fio/pull/526#issuecomment-369521772 we found
> the main device doesn't record stats. Will that still be the case?
The stats still live in the same place at
/sys/block/nvmeXcYnZ/queue/stats. This patch just removes symlinks to the
each path block device in the multipath block device's slave directory,
so 'fio' won't see them at the moment.
next prev parent reply other threads:[~2018-03-07 20:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 13:13 [PATCH] Revert "nvme: create 'slaves' and 'holders' entries for hidden controllers" Christoph Hellwig
2018-03-07 13:40 ` Hannes Reinecke
2018-03-07 15:03 ` Keith Busch
2018-03-07 15:56 ` Sitsofe Wheeler
2018-03-07 17:18 ` Christoph Hellwig
2018-03-07 17:38 ` Keith Busch
2018-03-07 17:47 ` Sitsofe Wheeler
2018-03-07 20:37 ` Keith Busch [this message]
2018-03-07 21:42 ` Sitsofe Wheeler
2018-03-08 17:14 ` Sagi Grimberg
2018-03-08 22:45 ` Keith Busch
2018-03-09 8:51 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307203741.GC3766@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=axboe@kernel.dk \
--cc=bharat@chelsio.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=kzak@redhat.com \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sitsofe@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox