From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:37388 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932137AbeCHRjQ (ORCPT ); Thu, 8 Mar 2018 12:39:16 -0500 Date: Thu, 8 Mar 2018 09:39:14 -0800 From: Darren Hart To: Sasha Levin Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Santeri Toivonen Subject: Re: [PATCH AUTOSEL for 4.9 025/190] platform/x86: asus-nb-wmi: Add wapf4 quirk for the X302UA Message-ID: <20180308173914.GC11045@localhost.localdomain> References: <20180308045810.8041-1-alexander.levin@microsoft.com> <20180308045810.8041-25-alexander.levin@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180308045810.8041-25-alexander.levin@microsoft.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Mar 08, 2018 at 04:59:01AM +0000, Sasha Levin wrote: > From: Santeri Toivonen > > [ Upstream commit f35823619db8bbaa2afea8705f239c3cecb9d22f ] > > Asus laptop X302UA starts up with Wi-Fi disabled, > without a way to enable it. Set wapf=4 to fix the problem. > > Signed-off-by: Santeri Toivonen > Signed-off-by: Darren Hart (VMware) > Signed-off-by: Sasha Levin Hi Sasha, I'm curious about this AUTOSEL tag, and what about this patch triggered its selection? Pulling changes like this can be risky if they aren't done sequentially, resulting in the stable driver having a spotty patching. I don't necessarily object to *this* patch, but in general, I want to understand what triggers the selection of patches that maintainers have not tagged with stable and which do not contain fixes tags. -- Darren Hart VMware Open Source Technology Center