Re: [PATCH 4.4 24/36] netlink: ensure to loop over all netns in genlmsg_multicast_allns()

Nicolas Dichtel
2018-03-14T17:06:21Z

Le 13/03/2018 à 01:04, Ben Hutchings a écrit :
> On Fri, 2018-03-09 at 16:18 -0800, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>>
>> ------------------
>>
>> From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>
>>
>> [ Upstream commit cb9f7a9a5c96a773bbc9c70660dc600cfff82f82 ]
> [...]
>> - return nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> + err = nlmsg_multicast(prev->genl_sock, skb, portid, group, flags);
>> + if (!err)
>> + delivered = true;
>> + else if (err != -ESRCH)
>> + goto error;
>
> This call to nlmsg_multicast() consumes skb rather than a clone, so we
> must not free it again here.
Right, good catch.

I will send an update.

Regards,
Nicolas