From: Andrew Morton <akpm@linux-foundation.org>
To: Jerome Glisse <jglisse@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Ralph Campbell <rcampbell@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>,
Evgeny Baskakov <ebaskakov@nvidia.com>
Subject: Re: [PATCH 02/14] mm/hmm: fix header file if/else/endif maze
Date: Fri, 16 Mar 2018 14:35:37 -0700 [thread overview]
Message-ID: <20180316143537.0d49a76ec48ec0ab034af93b@linux-foundation.org> (raw)
In-Reply-To: <20180316211801.GB4861@redhat.com>
On Fri, 16 Mar 2018 17:18:02 -0400 Jerome Glisse <jglisse@redhat.com> wrote:
> On Fri, Mar 16, 2018 at 02:09:59PM -0700, Andrew Morton wrote:
> > On Fri, 16 Mar 2018 15:14:07 -0400 jglisse@redhat.com wrote:
> >
> > > From: Jérôme Glisse <jglisse@redhat.com>
> > >
> > > The #if/#else/#endif for IS_ENABLED(CONFIG_HMM) were wrong.
> >
> > "were wrong" is not a sufficient explanation of the problem, especially
> > if we're requesting a -stable backport. Please fully describe the
> > effects of a bug when fixing it?
>
> Build issue (compilation failure) if you have multiple includes of
> hmm.h through different headers is the most obvious issue. So it
> will be very obvious with any big driver that include the file in
> different headers.
That doesn't seem to warrant a -stable backport? The developer of such
a driver will simply fix the headers?
> I can respin with that. Sorry again for not being more explanatory
> it is always hard for me to figure what is not obvious to others.
I updated the changelog, no respin needed.
next prev parent reply other threads:[~2018-03-16 21:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180316191414.3223-1-jglisse@redhat.com>
2018-03-16 19:14 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze jglisse
2018-03-16 21:09 ` Andrew Morton
2018-03-16 21:18 ` Jerome Glisse
2018-03-16 21:35 ` Andrew Morton [this message]
2018-03-16 21:40 ` John Hubbard
2018-03-17 1:20 ` [PATCH 02/14] mm/hmm: fix header file if/else/endif maze v2 jglisse
2018-03-16 19:14 ` [PATCH 03/14] mm/hmm: HMM should have a callback before MM is destroyed v2 jglisse
2018-03-16 21:12 ` Andrew Morton
2018-03-16 21:26 ` Jerome Glisse
2018-03-16 21:37 ` John Hubbard
2018-03-17 2:36 ` John Hubbard
2018-03-17 3:47 ` John Hubbard
2018-03-17 4:39 ` John Hubbard
2018-03-16 19:14 ` [PATCH 04/14] mm/hmm: hmm_pfns_bad() was accessing wrong struct jglisse
2018-03-17 2:04 ` John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316143537.0d49a76ec48ec0ab034af93b@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ebaskakov@nvidia.com \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rcampbell@nvidia.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox