Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Dave Chinner <david@fromorbit.com>,
	Christoph Hellwig <hch@lst.de>,
	"Darrick J. Wong" <darrick.wong@oracle.com>,
	Eryu Guan <eguan@redhat.com>,
	linux-xfs <linux-xfs@vger.kernel.org>,
	stable <stable@vger.kernel.org>
Subject: Re: [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode
Date: Mon, 19 Mar 2018 14:40:13 +0100	[thread overview]
Message-ID: <20180319134013.GE27855@kroah.com> (raw)
In-Reply-To: <CAOQ4uxgsMwtQRCkpJTJoVO-mbU1yRz7F0pMOAVcJphEEKq8SHA@mail.gmail.com>

On Wed, Mar 14, 2018 at 08:24:30AM +0200, Amir Goldstein wrote:
> On Tue, Mar 13, 2018 at 11:50 PM, Dave Chinner <david@fromorbit.com> wrote:
> > On Tue, Mar 13, 2018 at 04:33:15PM +0200, Amir Goldstein wrote:
> >> On Tue, Mar 13, 2018 at 3:11 PM, Christoph Hellwig <hch@lst.de> wrote:
> >> > On Tue, Mar 13, 2018 at 02:46:09PM +0200, Amir Goldstein wrote:
> >> >> OK, found the patches the fix soft lockups in generic/269 and
> >> >> assertion in generic/232, so expunging those 2 tests from v4.15.y
> >> >> test runs.
> >> >
> >> > Which patches are those?  We should probably backport them to 4.15-stable.
> >>
> >> Probably, but I guess Darrick has those in his TODO.
> >>
> >> There is this series that refers to failure in generic/232:
> >> https://marc.info/?l=linux-xfs&m=151701545720824&w=2
> >>
> >> These 2 commits refer to generic/269 specifically in commit message:
> >>  70c57dcd606f xfs: skip CoW writes past EOF when writeback races with truncate
> >>  be78ff0e7277 xfs: recheck reflink / dirty page status before freeing
> >> CoW reservations
> >> and the thread on the second commit also mentions generic/270
> >> (I found out the hard way that it also soft locks).
> >>
> >> But there are surely more patches for stable in master.
> >> I recon CC: stable and/or Fixes: tags could have been helpful,
> >> but I don't see any of those in v4.16-rcX from the core xfs developers.
> >
> > AS I always say: if you want to maintain a stable backport kernel
> > with all the fixes that go into the bleeding edge, you're more than
> > welcome to do it.
> >
> > Everyone else is flat out just keeping up with on going development
> > and fixing bugs in the kernel as it's moving forward. So if you have
> > the need for stable backports, please keep backporting patches you
> > need, testing them and asking the stable maintainers to include
> > them.
> >
> 
> Greg,
> 
> I tested the patch in question per Darrick's request.
> I found no regressions with full "auto" run on xfs with reflinks enabled.
> Please include this patch in stable 4.15.

I have no idea anymore what "this patch" means here :(

Please resend the git commit id of what I need to apply to where.

thanks,

greg k-h

  parent reply	other threads:[~2018-03-19 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1516952669-14769-1-git-send-email-amir73il@gmail.com>
     [not found] ` <20180126214404.GE9068@magnolia>
     [not found]   ` <CAOQ4uxgVaGgwio=538-PP4QuRbcny6q0_CAeV-9bQEWBaxv2gA@mail.gmail.com>
     [not found]     ` <20180129155054.GJ9359@magnolia>
     [not found]       ` <CAOQ4uxjMfZGMtbq2vRN8dL5QvgC0=UD-yWDbNib=dckDTFR0Nw@mail.gmail.com>
2018-02-01  0:29         ` [PATCH v2] xfs: preserve i_rdev when recycling a reclaimable inode Amir Goldstein
     [not found]         ` <20180201003511.GK4849@magnolia>
     [not found]           ` <CAOQ4uxjE31j7XDpEGnnym7cgD_kqsPnio4KN2gphajsCNMrG1g@mail.gmail.com>
     [not found]             ` <20180311162442.GB2013@kroah.com>
     [not found]               ` <20180312162744.GB4865@magnolia>
     [not found]                 ` <CAOQ4uxjn8UN2-Hzr8u404ydKf8s41yVpMA93-n7r6Dr2VBz3dA@mail.gmail.com>
     [not found]                   ` <CAOQ4uxhdkhZup=ndukKCRtU13YVs8jQxT0zgOT_XN3_-tB8TfQ@mail.gmail.com>
     [not found]                     ` <CAOQ4uxhCjBA99X_C-GpEBf=jC4S_wSrxMwS6Ovj7BtWLK1GmUA@mail.gmail.com>
     [not found]                       ` <20180313131109.GB6260@lst.de>
     [not found]                         ` <CAOQ4uxiDHSC19-fRdZmXM5BJB3-p9_LdPgSmxpjGrdCzhV2W2Q@mail.gmail.com>
     [not found]                           ` <20180313215028.GE18129@dastard>
2018-03-14  6:24                             ` Amir Goldstein
2018-03-14 12:33                               ` Dave Chinner
2018-03-14 12:49                                 ` Christoph Hellwig
2018-03-14 15:45                                   ` Amir Goldstein
2018-03-14 15:46                                     ` Christoph Hellwig
2018-03-14 16:01                                     ` Darrick J. Wong
2018-03-19 13:40                               ` Greg KH [this message]
2018-03-19 14:59                                 ` Amir Goldstein
2018-03-19 15:19                                   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180319134013.GE27855@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amir73il@gmail.com \
    --cc=darrick.wong@oracle.com \
    --cc=david@fromorbit.com \
    --cc=eguan@redhat.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox