From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw0-f177.google.com ([209.85.161.177]:37084 "EHLO mail-yw0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933559AbeCSObu (ORCPT ); Mon, 19 Mar 2018 10:31:50 -0400 Date: Mon, 19 Mar 2018 07:31:47 -0700 From: Tejun Heo To: Bart Van Assche Cc: "Martin K . Petersen" , "James E . J . Bottomley" , linux-scsi@vger.kernel.org, Hannes Reinecke , Ming Lei , Christoph Hellwig , Johannes Thumshirn , Oleksandr Natalenko , Martin Steigerwald , stable@vger.kernel.org Subject: Re: [PATCH] Change synchronize_rcu() in scsi_device_quiesce() into synchronize_sched() Message-ID: <20180319143147.GF2943022@devbig577.frc2.facebook.com> References: <20180316173516.3048-1-bart.vanassche@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180316173516.3048-1-bart.vanassche@wdc.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Mar 16, 2018 at 10:35:16AM -0700, Bart Van Assche wrote: > Since blk_queue_enter() uses rcu_read_lock_sched() scsi_device_quiesce() > must use synchronize_sched(). Is there a reason to use sched-RCU here instead of the regular one? If not, it'd be better to switch to regular RCU than the other way around. Thanks. -- tejun