From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f66.google.com ([209.85.160.66]:33529 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755426AbeCSXwy (ORCPT ); Mon, 19 Mar 2018 19:52:54 -0400 Received: by mail-pl0-f66.google.com with SMTP id c11-v6so11267299plo.0 for ; Mon, 19 Mar 2018 16:52:53 -0700 (PDT) Date: Tue, 20 Mar 2018 07:52:51 +0800 From: Dan Rue To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Tero Kristo , Roger Quadros , Tony Lindgren , Sasha Levin Subject: Re: [PATCH 4.4 038/134] ARM: DRA7: hwmod_data: Prevent wait_target_disable error for usb_otg_ss Message-ID: <20180319235251.ui2gf3nlg2icbbdx@xps> References: <20180319171849.024066323@linuxfoundation.org> <20180319171854.858515505@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180319171854.858515505@linuxfoundation.org> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 19, 2018 at 07:05:21PM +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Roger Quadros > > > [ Upstream commit e2d54fe76997301b49311bde7ba8ef52b47896f9 ] > > It seems that if L3_INIT clkdomain is kept in HW_AUTO while usb_otg_ss > is in use then there are random chances that the usb_otg_ss module > will fail to completely idle. i.e. IDLEST = 0x2 instead of 0x3. > > Preventing L3_INIT from HW_AUTO while usb_otg_ss module is in use > fixes this issue. > > We don't know yet if usb_otg_ss instances 3 and 4 are affected by this > issue or not so don't add this flag for those instances. > > Cc: Tero Kristo > Signed-off-by: Roger Quadros > Signed-off-by: Tony Lindgren > Signed-off-by: Sasha Levin > Signed-off-by: Greg Kroah-Hartman This fails to build for me on arm32 with default config. # # make -j10 -k -s ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm multi_v7_defconfig # # # make -j10 -k -s ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- O=build-arm # ../arch/arm/mach-omap2/omap_hwmod_7xx_data.c:2243:12: error: 'HWMOD_CLKDM_NOAUTO' undeclared here (not in a function) .flags = HWMOD_CLKDM_NOAUTO, ^ ../scripts/Makefile.build:269: recipe for target 'arch/arm/mach-omap2/omap_hwmod_7xx_data.o' failed make[2]: *** [arch/arm/mach-omap2/omap_hwmod_7xx_data.o] Error 1 make[2]: Target '__build' not remade because of errors. /home/buildslave/workspace/kernel-single-defconfig-builder/defconfig/multi_v7_defconfig/label/builder/Makefile:969: recipe for target 'arch/arm/mach-omap2' failed make[1]: *** [arch/arm/mach-omap2] Error 2 make[1]: Target '_all' not remade because of errors. Makefile:152: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 make: Target '_all' not remade because of errors. Dan > --- > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 2 ++ > 1 file changed, 2 insertions(+) > > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c > @@ -2240,6 +2240,7 @@ static struct omap_hwmod dra7xx_usb_otg_ > .class = &dra7xx_usb_otg_ss_hwmod_class, > .clkdm_name = "l3init_clkdm", > .main_clk = "dpll_core_h13x2_ck", > + .flags = HWMOD_CLKDM_NOAUTO, > .prcm = { > .omap4 = { > .clkctrl_offs = DRA7XX_CM_L3INIT_USB_OTG_SS1_CLKCTRL_OFFSET, > @@ -2261,6 +2262,7 @@ static struct omap_hwmod dra7xx_usb_otg_ > .class = &dra7xx_usb_otg_ss_hwmod_class, > .clkdm_name = "l3init_clkdm", > .main_clk = "dpll_core_h13x2_ck", > + .flags = HWMOD_CLKDM_NOAUTO, > .prcm = { > .omap4 = { > .clkctrl_offs = DRA7XX_CM_L3INIT_USB_OTG_SS2_CLKCTRL_OFFSET, > >