* Re: [PATCH v2] drm/i915/gvt: throw error on unhandled vfio ioctls
[not found] <20180321090804.22430-1-kraxel@redhat.com>
@ 2018-03-21 12:58 ` Alex Williamson
0 siblings, 0 replies; only message in thread
From: Alex Williamson @ 2018-03-21 12:58 UTC (permalink / raw)
To: Gerd Hoffmann
Cc: intel-gvt-dev, dri-devel, stable, Zhenyu Wang, Zhi Wang,
Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
intel-gvt-dev, intel-gfx, linux-kernel
On Wed, 21 Mar 2018 10:08:03 +0100
Gerd Hoffmann <kraxel@redhat.com> wrote:
> On unknown/unhandled ioctls the driver should return an error, so
> userspace knows it tried to use something unsupported.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/gpu/drm/i915/gvt/kvmgt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index 021f722e24..be881d53c2 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -1284,7 +1284,7 @@ static long intel_vgpu_ioctl(struct mdev_device *mdev, unsigned int cmd,
>
> }
>
> - return 0;
> + return -EINVAL;
> }
>
> static ssize_t
Absolutely, but I'd prefer to continue the standard behavior among
other vfio drivers, and adopted from elsewhere in the kernel, to use
-ENOTTY for an unhandled ioctl, reserving -EINVAL as an error in
options for a supported ioctl. Thanks,
Alex
^ permalink raw reply [flat|nested] only message in thread