From: Greg KH <gregkh@linuxfoundation.org>
To: Harsh Shandilya <msfjarvis@gmail.com>
Cc: Vic Wei <vwei@codeaurora.org>,
marcel@holtmann.org, linux-kernel@vger.kernel.org,
majordomo@vger.kernel.org, stable@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-arm-kernel@vger.kernel.org,
kumo@qti.qualcomm.com, vwei@qti.qualcomm.com
Subject: Re: [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME
Date: Wed, 21 Mar 2018 20:38:14 +0100 [thread overview]
Message-ID: <20180321193814.GB19781@kroah.com> (raw)
In-Reply-To: <FD229C76-5144-46E0-B7DE-47333B3B4D03@gmail.com>
On Wed, Mar 21, 2018 at 11:40:07PM +0530, Harsh Shandilya wrote:
>
>
> On 21 March 2018 9:54:37 PM IST, Greg KH <gregkh@linuxfoundation.org> wrote:
> >On Wed, Mar 21, 2018 at 09:09:57AM -0700, Vic Wei wrote:
> >> QCA Rome controllers can do both LE scan and BR/EDR inquiry at once.
> >>
> >> Change-Id: I89e1412d635f4cd7b2500f7492f37430ea139f0c
> >
> >What is this line for?
>
> That's the Change ID required by everything that goes through Gerrit. CAF (I'm assuming Vic is from CodeAurora Forums judging by the email) uses Gerrit as their review platform for the Android for MSM project.
It was a rhetorical question, I know what it is, and the fact that it
should not be in a kernel patch submission, I wanted the submitter to
learn to read their own patches _before_ they send them in.
Also, if they used checkpatch.pl, it would have told them to remove
this.
It's like saying to a kid, "what is this mess on the floor"...
greg k-h
prev parent reply other threads:[~2018-03-21 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:09 [PATCH 1/1] Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for BTUSB_QCA_ROME Vic Wei
2018-03-21 16:24 ` Greg KH
2018-03-21 18:10 ` Harsh Shandilya
2018-03-21 19:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180321193814.GB19781@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kumo@qti.qualcomm.com \
--cc=linux-arm-kernel@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=majordomo@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=msfjarvis@gmail.com \
--cc=stable@vger.kernel.org \
--cc=vwei@codeaurora.org \
--cc=vwei@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox