From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:36187 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751748AbeCWHvU (ORCPT ); Fri, 23 Mar 2018 03:51:20 -0400 Date: Fri, 23 Mar 2018 08:51:15 +0100 From: Boris Brezillon To: Jagdish Gediya Cc: linux-mtd@lists.infradead.org, boris.brezillon@free-electrons.com, stable@vger.kernel.org, leoyang.li@nxp.com, oss@buserror.net, computersforpeace@gmail.com Subject: Re: [PATCH][v3] mtd: rawnand: fsl_ifc: Fix nand waitfunc return value Message-ID: <20180323085115.1c9af019@bbrezillon> In-Reply-To: <1521586908-7667-1-git-send-email-jagdish.gediya@nxp.com> References: <1521586908-7667-1-git-send-email-jagdish.gediya@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Wed, 21 Mar 2018 04:31:36 +0530 Jagdish Gediya wrote: > As per the IFC hardware manual, Most significant 2 bytes in > nand_fsr register are the outcome of NAND READ STATUS command. > > So status value need to be shifted and aligned as per the nand > framework requirement. > > Fixes: 82771882d960 ("NAND Machine support for Integrated Flash Controller") > Cc: stable@vger.kernel.org # v3.18+ > Signed-off-by: Jagdish Gediya > Reviewed-by: Prabhakar Kushwaha Applied. Thanks, Boris > --- > Changes for v2: Incorporated comments from Boris Brezillon > - Added fixes tag > > Changes for v3: Incorporated comments from Boris Brezillon > > drivers/mtd/nand/fsl_ifc_nand.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/mtd/nand/fsl_ifc_nand.c b/drivers/mtd/nand/fsl_ifc_nand.c > index 9390cbd..16104ca 100644 > --- a/drivers/mtd/nand/fsl_ifc_nand.c > +++ b/drivers/mtd/nand/fsl_ifc_nand.c > @@ -629,6 +629,7 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip) > struct fsl_ifc_ctrl *ctrl = priv->ctrl; > struct fsl_ifc_runtime __iomem *ifc = ctrl->rregs; > u32 nand_fsr; > + int status; > > /* Use READ_STATUS command, but wait for the device to be ready */ > ifc_out32((IFC_FIR_OP_CW0 << IFC_NAND_FIR0_OP0_SHIFT) | > @@ -643,12 +644,12 @@ static int fsl_ifc_wait(struct mtd_info *mtd, struct nand_chip *chip) > fsl_ifc_run_command(mtd); > > nand_fsr = ifc_in32(&ifc->ifc_nand.nand_fsr); > - > + status = nand_fsr >> 24; > /* > * The chip always seems to report that it is > * write-protected, even when it is not. > */ > - return nand_fsr | NAND_STATUS_WP; > + return status | NAND_STATUS_WP; > } > > /* -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com