From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60593 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750942AbeC0H3x (ORCPT ); Tue, 27 Mar 2018 03:29:53 -0400 Date: Tue, 27 Mar 2018 09:29:50 +0200 From: Greg KH To: Jason Ekstrand Cc: stable@vger.kernel.org, dri-devel@lists.freedesktop.org, Chris Wilson , Dave Airlie Subject: Re: [PATCH] drm/syncobj: Stop reusing the same struct file for all syncobj -> fd Message-ID: <20180327072950.GB8380@kroah.com> References: <1522090837-13789-1-git-send-email-jason.ekstrand@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522090837-13789-1-git-send-email-jason.ekstrand@intel.com> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 26, 2018 at 12:00:37PM -0700, Jason Ekstrand wrote: > From: Chris Wilson > > The vk cts test: > dEQP-VK.api.external.semaphore.opaque_fd.export_multiple_times_temporary > > triggers a lot of > VFS: Close: file count is 0 > > Dave pointed out that clearing the syncobj->file from > drm_syncobj_file_release() was sufficient to silence the test, but that > opens a can of worm since we assumed that the syncobj->file was never > unset. Stop trying to reuse the same struct file for every fd pointing > to the drm_syncobj, and allocate one file for each fd instead. > > v2: Fixup return handling of drm_syncobj_fd_to_handle > v2.1: [airlied: fix possible syncobj ref race] > v2.2: [jekstrand: back-port to 4.14] > > Reported-by: Dave Airlie > Signed-off-by: Chris Wilson > Tested-by: Dave Airlie > Reviewed-by: Daniel Vetter > Signed-off-by: Dave Airlie > Signed-off-by: Jason Ekstrand > Tested-by: Clayton Craft > --- > > The back-port from 4.15 to 4.14 was non-trivial. It'd be good if Chris and > maybe Daniel could do a quick re-review. Now queued up, thanks. greg k-h