From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:38448 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbeC0JYo (ORCPT ); Tue, 27 Mar 2018 05:24:44 -0400 Date: Tue, 27 Mar 2018 10:24:38 +0100 From: James Hogan To: "Maciej W. Rozycki" Cc: Ralf Baechle , Maxim Uvarov , linux-mips@linux-mips.org, stable@vger.kernel.org Subject: Re: [PATCH] MIPS: Make the default for PHYSICAL_START always 64-bit Message-ID: <20180327092438.GA17660@saruman> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="nFreZHaLTZJo0R7j" Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: --nFreZHaLTZJo0R7j Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 26, 2018 at 07:11:51PM +0100, Maciej W. Rozycki wrote: > Make the default for PHYSICAL_START always 64-bit, ensuring that a=20 > correct sign-extended value is used if a 32-bit image is loaded by a=20 > 64-bit system, and matching how the load address is set in platform=20 > Makefile fragments (arch/mips/*/Platform) in the absence of the=20 > PHYSICAL_START configuration option. This looks correct given the defaults in the Makefile fragments. However I presume a 32BIT kernel will produce a 32-bit ELF, in which case the result will be indistinguishable? For other kernel image formats which always use 64-bit pointers perhaps it matters more (if they can be loaded by kexec-tools). uImage is 32-bit ISTR, and our ITB stuff seems to only use 32bit addresses for CONFIG_32BIT. I don't now about other formats. So unless I hear otherwise I'll probably drop the stable tag and apply for 4.17. Thanks James --nFreZHaLTZJo0R7j Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEd80NauSabkiESfLYbAtpk944dnoFAlq6DcwACgkQbAtpk944 dnqrAg/+MmTLbAHANlFE1Kgm/OhkAMvFiHa8L3FeJFO+jr/e8slGq0rTOgqT2ekD YU4zb5OjKRTM14vejvml6HF6ZaXPlSXTikfiW38ATBs9zOdV4351YedfFzuog2E8 LZ7N+qbdm3y34IiX28/BllF/ZyyNk39UnP2VGzrY6iyFuXLQEFDQAFUmW7CkcMem QE2TZx0shkmMZ5yQGUpfb7c5/aqo74kX8HP80F+UyvmR5JcWDFvTipZQZtCLjQa0 s/SZlSUqv5wkYrDa81D6XtKNcBv+iHo3UhKRpmKPAUVRXp4N9x3GRkiiB6GkmDiR koSQ8JwCDyTRhmUnMoq4Fhbn7gsP+equ32VCXpm5ZfmGbptJrE7dlSvHWB9yfFbN CZDzQkHpdqwDCWN1TuFi9t8/HWZMPCwNhbr/bL0aAKnzOtXFn979fRCriHufT6Rh LvFnFIA6zxjZN/sDcsswQAPRFFCUEOeOaA20o1jrvnwE789p+kgzeY+No/S3N2ra Yp5q+ZLl1pOmsodjxgAJyws4XnSXThDNZGNTwQUWkkxWCDIoExcpe/rCEFBWnSBH zFI3iFFVEKZWUxfP92ALXq8Y5IQAcwj5aPF/ujAB8Xy0ymQMQTiOlszvE0oiHn3e o2dEzye6rruk5JMXJEu7WjMEyW1duru316CLqZPNUc8ZISCGBUg= =PEP7 -----END PGP SIGNATURE----- --nFreZHaLTZJo0R7j--