From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f196.google.com ([74.125.82.196]:40107 "EHLO mail-ot0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751028AbeC0UsB (ORCPT ); Tue, 27 Mar 2018 16:48:01 -0400 Date: Tue, 27 Mar 2018 13:47:55 -0700 From: Nathan Chancellor To: "Kani, Toshi" Cc: "dan.rue@linaro.org" , "linux-kernel@vger.kernel.org" , "torvalds@linux-foundation.org" , "bp@suse.de" , "tglx@linutronix.de" , "lious.lilei@hisilicon.com" , "guohanjun@huawei.com" , "wxf.wang@hisilicon.com" , "stable@vger.kernel.org" , "akpm@linux-foundation.org" , "hpa@zytor.com" , "will.deacon@arm.com" , "catalin.marinas@arm.com" , "mingo@redhat.com" , "gregkh@linuxfoundation.org" , "Hocko, Michal" , "cpandya@codeaurora.org" , "willy@infradead.org" Subject: Re: [PATCH 4.4 20/43] mm/vmalloc: add interfaces to free unmapped page table Message-ID: <20180327204755.GA19436@localhost> References: <20180327162716.407986916@linuxfoundation.org> <20180327162717.580646019@linuxfoundation.org> <20180327201700.xmgzgqox3sz3z32r@xps> <20180327203130.GA18921@localhost> <1522183239.2693.240.camel@hpe.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1522183239.2693.240.camel@hpe.com> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Mar 27, 2018 at 08:40:56PM +0000, Kani, Toshi wrote: > On Tue, 2018-03-27 at 13:31 -0700, Nathan Chancellor wrote: > > On Tue, Mar 27, 2018 at 03:17:00PM -0500, Dan Rue wrote: > > > On Tue, Mar 27, 2018 at 06:27:24PM +0200, Greg Kroah-Hartman wrote: > > > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > > : > > > > > > This patch causes the following build error on 4.4 arm64: > > > > > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 defconfig > > > $ make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- O=build-arm64 > > > > > > CC arch/arm64/mm/mmu.o > > > ../arch/arm64/mm/mmu.c:701:5: error: redefinition of ‘pud_free_pmd_page’ > > > int pud_free_pmd_page(pud_t *pud) > > > ^~~~~~~~~~~~~~~~~ > > > In file included from ../arch/arm64/include/asm/pgtable.h:682:0, > > > from ../include/linux/mm.h:55, > > > from ../include/linux/mman.h:4, > > > from ../arch/arm64/mm/mmu.c:25: > > > ../include/asm-generic/pgtable.h:777:19: note: previous definition of ‘pud_free_pmd_page’ was here > > > static inline int pud_free_pmd_page(pud_t *pud) > > > ^~~~~~~~~~~~~~~~~ > > > ../arch/arm64/mm/mmu.c:706:5: error: redefinition of ‘pmd_free_pte_page’ > > > int pmd_free_pte_page(pmd_t *pmd) > > > ^~~~~~~~~~~~~~~~~ > > > In file included from ../arch/arm64/include/asm/pgtable.h:682:0, > > > from ../include/linux/mm.h:55, > > > from ../include/linux/mman.h:4, > > > from ../arch/arm64/mm/mmu.c:25: > > > ../include/asm-generic/pgtable.h:781:19: note: previous definition of ‘pmd_free_pte_page’ was here > > > static inline int pmd_free_pte_page(pmd_t *pmd) > > > ^~~~~~~~~~~~~~~~~ > > > make[2]: *** [../scripts/Makefile.build:270: arch/arm64/mm/mmu.o] Error 1 > > > make[1]: *** [/home/drue/src/linux/4.4-rc/Makefile:969: arch/arm64/mm] Error 2 > > > make[1]: Leaving directory '/home/drue/src/linux/4.4-rc/build-arm64' > > > make: *** [Makefile:152: sub-make] Error 2 > > > > > > > > > > Both of my arm64 devices built fine with this patch... It seems like > > the only way to hit that error is if HAVE_ARCH_HUGE_VMAP isn't set, > > which seems impossible since it is selected by ARM64... > > > > Someone smarter than I might have more insight but this patch is > > unchanged from upstream so I can only assume that this error would > > manifest there as well. > > It appears that HAVE_ARCH_HUGE_VMAP was introduced in 4.6 on arm64. > Hence the problem in 4.4. > > Thanks, > -Toshi > Ah, thanks for the heads up, since I have 324420bf91f6 ("arm64: add support for ioremap() block mappings") in my tree due to Linaro's backport of it for their Linaro Stable Kernel, which serves as a base for most Android kernels. My apologies for not digging deeper and sorry for the noise! Cheers! Nathan