From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:46968 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750795AbeC2HZR (ORCPT ); Thu, 29 Mar 2018 03:25:17 -0400 Date: Thu, 29 Mar 2018 09:24:45 +0200 From: Greg KH To: Stephen Hemminger Cc: kys@exchange.microsoft.com, kys@microsoft.com, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com, vkuznets@redhat.com, jasowang@redhat.com, leann.ogasawara@canonical.com, marcelo.cerri@canonical.com, sthemmin@microsoft.com, Michael Kelley , Stable Subject: Re: [PATCH 1/1] Drivers: hv: vmbus: Fix ring buffer signaling Message-ID: <20180329072445.GA13733@kroah.com> References: <20180305052408.19475-1-kys@exchange.microsoft.com> <20180328120142.7ba72aa2@xeon-e3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180328120142.7ba72aa2@xeon-e3> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Mar 28, 2018 at 12:01:42PM -0700, Stephen Hemminger wrote: > On Sun, 4 Mar 2018 22:24:08 -0700 > kys@exchange.microsoft.com wrote: > > > From: Michael Kelley > > > > Fix bugs in signaling the Hyper-V host when freeing space in the > > host->guest ring buffer: > > > > 1. The interrupt_mask must not be used to determine whether to signal > > on the host->guest ring buffer > > 2. The ring buffer write_index must be read (via hv_get_bytes_to_write) > > *after* pending_send_sz is read in order to avoid a race condition > > 3. Comparisons with pending_send_sz must treat the "equals" case as > > not-enough-space > > 4. Don't signal if the pending_send_sz feature is not present. Older > > versions of Hyper-V that don't implement this feature will poll. > > > > Fixes: 03bad714a161 ("vmbus: more host signalling avoidance") > > > > Cc: Stable # 4.14 and above > > Signed-off-by: Michael Kelley > > Signed-off-by: K. Y. Srinivasan > > What ever happened to this patch? It doesn't seem to be in char-misc, upstream, > or stable kernel tree yet. > It was in the 4.14.31 and 4.15.14 stable releases. thanks, greg k-h