From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:35108 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750790AbeC3L7S (ORCPT ); Fri, 30 Mar 2018 07:59:18 -0400 Date: Fri, 30 Mar 2018 04:59:17 -0700 From: Christoph Hellwig To: Chaitra P B Cc: linux-scsi@vger.kernel.org, stable@vger.kernel.org, suganath-prabu.subramani@broadcom.com, Sathya.Prakash@broadcom.com, sreekanth.reddy@broadcom.com Subject: Re: [PATCH 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it. Message-ID: <20180330115917.GA30423@infradead.org> References: <1522402644-3016-1-git-send-email-chaitra.basappa@broadcom.com> <1522402644-3016-4-git-send-email-chaitra.basappa@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522402644-3016-4-git-send-email-chaitra.basappa@broadcom.com> Sender: stable-owner@vger.kernel.org List-ID: On Fri, Mar 30, 2018 at 03:07:12PM +0530, Chaitra P B wrote: > Check scsi tracker for NULL before accessing it. > And in some places there are possibilities for getting valid st > but still other fields are not set. Please explain how that could ever happen. You should never see a scsi_cmnd without the device pointer.