stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] partitions/msdos: Unable to mount UFS 44bsd partitions
@ 2018-04-01  0:38 Richard Narron
  2018-04-01  9:49 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 2+ messages in thread
From: Richard Narron @ 2018-04-01  0:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Jens Axboe, linux stable, YLT

The patch below was installed in Linux 4.16-rc1 as

commit 5f15684bd5e5ef39d4337988864fec8012471dda

It is a fix to the following 4.12-rc3 patch:

commit 223220356d5ebc05ead9a8d697abb0c0a906fc81

Please install the new patch wherever the old patch was installed.
--------------------------------------------------------------------------------

UFS partitions from newer versions of FreeBSD 10 and 11 use relative addressing 
for their subpartitions. But older versions of FreeBSD still use absolute 
addressing just like OpenBSD and NetBSD.

Instead of simply testing for a FreeBSD partition, the code needs to also
test if the starting offset of the C subpartition is zero.

https://bugzilla.kernel.org/show_bug.cgi?id=197733

Signed-off-by: Richard Narron <comet.berkeley@gmail.com>
---

--- a/block/partitions/msdos.c.orig	2017-11-05 13:05:14.000000000 -0800
+++ b/block/partitions/msdos.c	2017-11-06 09:46:00.148228242 -0800
@@ -301,7 +301,9 @@ static void parse_bsd(struct parsed_part
  			continue;
  		bsd_start = le32_to_cpu(p->p_offset);
  		bsd_size = le32_to_cpu(p->p_size);
-		if (memcmp(flavour, "bsd\0", 4) == 0)
+		/* FreeBSD has relative offset if C partition offset is zero */
+		if (memcmp(flavour, "bsd\0", 4) == 0 &&
+		    le32_to_cpu(l->d_partitions[2].p_offset) == 0)
  			bsd_start += offset;
  		if (offset == bsd_start && size == bsd_size)
  			/* full parent partition, we have it already */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] partitions/msdos: Unable to mount UFS 44bsd partitions
  2018-04-01  0:38 [PATCH 1/1] partitions/msdos: Unable to mount UFS 44bsd partitions Richard Narron
@ 2018-04-01  9:49 ` Greg Kroah-Hartman
  0 siblings, 0 replies; 2+ messages in thread
From: Greg Kroah-Hartman @ 2018-04-01  9:49 UTC (permalink / raw)
  To: Richard Narron; +Cc: Jens Axboe, linux stable, YLT

On Sat, Mar 31, 2018 at 05:38:20PM -0700, Richard Narron wrote:
> The patch below was installed in Linux 4.16-rc1 as
> 
> commit 5f15684bd5e5ef39d4337988864fec8012471dda
> 
> It is a fix to the following 4.12-rc3 patch:
> 
> commit 223220356d5ebc05ead9a8d697abb0c0a906fc81
> 
> Please install the new patch wherever the old patch was installed.
> --------------------------------------------------------------------------------
> 

Now queued up, thanks.

greg k-h

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-01  9:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-01  0:38 [PATCH 1/1] partitions/msdos: Unable to mount UFS 44bsd partitions Richard Narron
2018-04-01  9:49 ` Greg Kroah-Hartman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).