From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-dm3nam03on0104.outbound.protection.outlook.com ([104.47.41.104]:32160 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750905AbeDCD1S (ORCPT ); Mon, 2 Apr 2018 23:27:18 -0400 From: Sasha Levin To: Ido Schimmel CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , "David S . Miller" Subject: Re: [PATCH AUTOSEL for 4.15 058/124] ipv6: Set nexthop flags during route creation Date: Tue, 3 Apr 2018 03:27:16 +0000 Message-ID: <20180403032714.GJ7561@sasha-vm> References: <20180319154645.11350-1-alexander.levin@microsoft.com> <20180319154645.11350-58-alexander.levin@microsoft.com> <20180319180434.GA13336@splinter> In-Reply-To: <20180319180434.GA13336@splinter> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <66319DE7808FD7409CBD5B3427E64CE5@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org List-ID: On Mon, Mar 19, 2018 at 08:04:34PM +0200, Ido Schimmel wrote: >On Mon, Mar 19, 2018 at 03:48:00PM +0000, Sasha Levin wrote: >> From: Ido Schimmel >> >> [ Upstream commit 5609b80a37f69f796548339e675256188b29c17d ] >> >> It is valid to install routes with a nexthop device that does not have a >> carrier, so we need to make sure they're marked accordingly. >> >> As explained in the previous patch, host and anycast routes are never >> marked with the 'linkdown' flag. >> >> Note that reject routes are unaffected, as these use the loopback device >> which always has a carrier. >> >> Signed-off-by: Ido Schimmel >> Acked-by: David Ahern >> Signed-off-by: David S. Miller >> Signed-off-by: Sasha Levin > >Hi Sasha, > >It doesn't really make sense to take this patch to 4.15 (and 4.14 from >your other mail). The flag is never used there. > >In these kernels the flag is dumped to user space based on a carrier >check. See commit 44c9f2f206f8 ("ipv6: Check nexthop flags in route dump >instead of carrier"). > >Similarly, during route lookup the carrier is checked and not the flag. >See commit 14c5206c2d02 ("ipv6: Check nexthop flags during route lookup >instead of carrier"). > >Thanks Now removed, thanks!=