From: Sasha Levin <Alexander.Levin@microsoft.com>
To: David Lechner <david@lechnology.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH AUTOSEL for 4.15 104/124] clk: fix reentrancy of clk_enable() on UP systems
Date: Tue, 3 Apr 2018 03:27:41 +0000 [thread overview]
Message-ID: <20180403032740.GL7561@sasha-vm> (raw)
In-Reply-To: <6a944b80-c86c-ca23-5ada-f088d84c9a80@lechnology.com>
On Mon, Mar 19, 2018 at 10:55:16AM -0500, David Lechner wrote:
>On 03/19/2018 10:48 AM, Sasha Levin wrote:
>>From: David Lechner <david@lechnology.com>
>>
>>[ Upstream commit a12aa8a68dfef5de181f2e555aa950a0ab05411f ]
>>
>>Reentrant calls to clk_enable() are not working on UP systems. This is
>>caused by the fact spin_trylock_irqsave() always returns true when
>>CONFIG_SMP=n (and CONFIG_DEBUG_SPINLOCK=n) which causes the reference
>>counting to not work correctly when clk_enable_lock() is called twice
>>before clk_enable_unlock() is called (this happens when clk_enable()
>>is called from within another clk_enable()).
>>
>>This fixes the problem by skipping the call to spin_trylock_irqsave() on UP
>>systems and relying solely on reference counting. We also make sure to set
>>flags in this case so that we are not returning an uninitialized value.
>>
>>Suggested-by: Stephen Boyd <sboyd@codeaurora.org>
>>Signed-off-by: David Lechner <david@lechnology.com>
>>Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
>>Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
>>---
>
>I don't know of any existing bugs in v4.15 that this fixes, so I don't
>think this really fits the criteria for stable.
>
Now removed, thanks!
next prev parent reply other threads:[~2018-04-03 3:27 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 15:46 [PATCH AUTOSEL for 4.15 001/124] i40iw: Fix sequence number for the first partial FPDU Sasha Levin
2018-03-19 15:46 ` [PATCH AUTOSEL for 4.15 002/124] i40iw: Correct Q1/XF object count equation Sasha Levin
2018-03-19 15:46 ` [PATCH AUTOSEL for 4.15 003/124] i40iw: Validate correct IRD/ORD connection parameters Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 004/124] clk: meson: mpll: use 64-bit maths in params_from_rate Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 005/124] ARM: dts: ls1021a: add "fsl,ls1021a-esdhc" compatible string to esdhc node Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 006/124] Bluetooth: Add a new 04ca:3015 QCA_ROME device Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 007/124] ipv6: Reinject IPv6 packets if IPsec policy matches after SNAT Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 008/124] thermal: power_allocator: fix one race condition issue for thermal_instances list Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 009/124] perf probe: Find versioned symbols from map Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 010/124] perf probe: Add warning message if there is unexpected event name Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 011/124] perf evsel: Fix swap for samples with raw data Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 012/124] perf evsel: Enable ignore_missing_thread for pid option Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 013/124] net: hns3: free the ring_data structrue when change tqps Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 014/124] net: hns3: fix for getting auto-negotiation state in hclge_get_autoneg Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 015/124] net: hns3: add Asym Pause support to phy default features Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 016/124] l2tp: fix missing print session offset info Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 017/124] rds; Reset rs->rs_bound_addr in rds_add_bound() failure path Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 018/124] ACPI / video: Default lcd_only to true on Win8-ready and newer machines Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 019/124] net/mlx4_en: Change default QoS settings Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 020/124] IB/mlx5: Report inner RSS capability Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 021/124] VFS: close race between getcwd() and d_move() Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 022/124] watchdog: dw_wdt: add stop watchdog operation Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 023/124] clk: divider: fix incorrect usage of container_of Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 024/124] phy: phy-brcm-usb-init: DRD mode can cause crash on startup Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 025/124] clk: sunxi-ng: fix the A64/H5 clock description of DE2 CCU Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 026/124] PM / devfreq: Fix potential NULL pointer dereference in governor_store Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 027/124] gpiolib: don't dereference a desc before validation Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 028/124] net_sch: red: Fix the new offload indication Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 029/124] selftests/net: fix bugs in address and port initialization Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 030/124] thermal/drivers/hisi: Remove bogus const from function return type Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 031/124] RDMA/cma: Mark end of CMA ID messages Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 032/124] hwmon: (ina2xx) Make calibration register value fixed Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 033/124] f2fs: fix lock dependency in between dio_rwsem & i_mmap_sem Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 034/124] clk: sunxi-ng: a83t: Add M divider to TCON1 clock Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 035/124] media: videobuf2-core: don't go out of the buffer range Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 036/124] ASoC: Intel: Skylake: Disable clock gating during firmware and library download Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 037/124] ASoC: Intel: cht_bsw_rt5645: Analog Mic support Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 038/124] drm/msm: Fix NULL deref in adreno_load_gpu Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 039/124] IB/ipoib: Fix for notify send CQ failure messages Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 040/124] spi: sh-msiof: Fix timeout failures for TX-only DMA transfers Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 041/124] RDMA/hns: Update the usage of sr_max and rr_max field Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 042/124] scsi: libiscsi: Allow sd_shutdown on bad transport Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 043/124] scsi: mpt3sas: Proper handling of set/clear of "ATA command pending" flag Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 044/124] scsi: qla2xxx: Fix NULL pointer access for fcport structure Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 045/124] irqchip/ompic: fix return value check in ompic_of_init() Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 046/124] irqchip/gic-v3: Fix the driver probe() fail due to disabled GICC entry Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 047/124] ACPI: EC: Fix debugfs_create_*() usage Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 048/124] mac80211: Fix setting TX power on monitor interfaces Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 049/124] vfb: fix video mode and line_length being set when loaded Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 050/124] ACPICA: Recognize the Windows 10 version 1607 and 1703 OSI strings Sasha Levin
2018-03-26 9:12 ` Mario.Limonciello
2018-04-03 3:19 ` Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 051/124] crypto: crypto4xx - perform aead icv check in the driver Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 052/124] gpio: label descriptors using the device name Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 053/124] arm64: asid: Do not replace active_asids if already 0 Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 054/124] powernv-cpufreq: Add helper to extract pstate from PMSR Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 055/124] IB/rdmavt: Allocate CQ memory on the correct node Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 056/124] blk-mq: avoid to map CPU into stale hw queue Sasha Levin
2018-03-19 15:47 ` [PATCH AUTOSEL for 4.15 057/124] blk-mq: fix race between updating nr_hw_queues and switching io sched Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 058/124] ipv6: Set nexthop flags during route creation Sasha Levin
2018-03-19 18:04 ` Ido Schimmel
2018-03-21 21:02 ` Sasha Levin
2018-04-03 3:27 ` Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 059/124] backlight: tdo24m: Fix the SPI CS between transfers Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 060/124] nvme-fabrics: protect against module unload during create_ctrl Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 061/124] pinctrl: baytrail: Enable glitch filter for GPIOs used as interrupts Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 062/124] nvme_fcloop: disassocate local port structs Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 063/124] nvme_fcloop: fix abort race condition Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 064/124] tpm: return a TPM_RC_COMMAND_CODE response if command is not implemented Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 065/124] perf report: Fix a no annotate browser displayed issue Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 066/124] iio: imu: st_lsm6dsx: fix endianness in st_lsm6dsx_read_oneshot() Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 067/124] staging: lustre: disable preempt while sampling processor id Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 068/124] nvme: fix subsystem multiple controllers support check Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 069/124] ASoC: Intel: sst: Fix the return value of 'sst_send_byte_stream_mrfld()' Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 070/124] netfilter: core: only allow one nat hook per hook point Sasha Levin
2018-03-19 15:56 ` Florian Westphal
2018-03-19 17:01 ` Sasha Levin
2018-04-03 3:27 ` Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 071/124] power: supply: axp288_charger: Properly stop work on probe-error / remove Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 072/124] rt2x00: do not pause queue unconditionally on error path Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 073/124] wl1251: check return from call to wl1251_acx_arp_ip_filter Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 074/124] xfs: include inobt buffers in ifree tx log reservation Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 075/124] xfs: fix up agi unlinked list reservations Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 076/124] net/mlx5: Fix race for multiple RoCE enable Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 077/124] xfs: distinguish between corrupt inode and invalid inum in xfs_scrub_get_inode Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 078/124] net: hns3: Fix an error of total drop packet statistics Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 079/124] net: hns3: Fix a loop index error of tqp statistics query Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 080/124] net: hns3: Fix an error macro definition of HNS3_TQP_STAT Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 081/124] net: hns3: fix for changing MTU Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 082/124] bcache: ret IOERR when read meets metadata error Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 083/124] bcache: stop writeback thread after detaching Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 084/124] bcache: segregate flash only volume write streams Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 085/124] scsi: libsas: Use dynamic alloced work to avoid sas event lost Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 086/124] net: Fix netdev_WARN_ONCE macro Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 087/124] scsi: libsas: fix memory leak in sas_smp_get_phy_events() Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 088/124] scsi: libsas: fix error when getting phy events Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 089/124] scsi: libsas: initialize sas_phy status according to response of DISCOVER Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 090/124] net/mlx5e: IPoIB, Use correct timestamp in child receive flow Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 091/124] blk-mq: fix kernel oops in blk_mq_tag_idle() Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 092/124] tty: n_gsm: Allow ADM response in addition to UA for control dlci Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 094/124] serdev: Fix serdev_uevent failure on ACPI enumerated serdev-controllers Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 093/124] block, bfq: put async queues for root bfq groups too Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 095/124] xfs: harden directory integrity checks some more Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 096/124] EDAC, mv64x60: Fix an error handling path Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 097/124] block, scsi: Fix race between SPI domain validation and system suspend Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 098/124] uio_hv_generic: check that host supports monitor page Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 099/124] Bluetooth: hci_bcm: Mandate presence of shutdown and device wake GPIO Sasha Levin
2018-03-19 18:53 ` Lukas Wunner
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 100/124] Bluetooth: hci_bcm: Validate IRQ before using it Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 101/124] i40evf: don't rely on netif_running() outside rtnl_lock() Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 102/124] drm/amd/powerplay: fix memory leakage when reload (v2) Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 103/124] cxgb4vf: Fix SGE FL buffer initialization logic for 64K pages Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 104/124] clk: fix reentrancy of clk_enable() on UP systems Sasha Levin
2018-03-19 15:55 ` David Lechner
2018-03-19 16:58 ` Sasha Levin
2018-04-03 3:27 ` Sasha Levin [this message]
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 105/124] PM / domains: Don't skip driver's ->suspend|resume_noirq() callbacks Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 106/124] scsi: megaraid_sas: Error handling for invalid ldcount provided by firmware in RAID map Sasha Levin
2018-03-19 15:48 ` [PATCH AUTOSEL for 4.15 107/124] scsi: megaraid_sas: unload flag should be set after scsi_remove_host is called Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 108/124] RDMA/cma: Fix rdma_cm path querying for RoCE Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 109/124] gpio: thunderx: fix error return code in thunderx_gpio_probe() Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 110/124] x86/gart: Exclude GART aperture from vmcore Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 111/124] sdhci: Advertise 2.0v supply on SDIO host controller Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 112/124] ibmvnic: Don't handle RX interrupts when not up Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 113/124] Input: goodix - disable IRQs while suspended Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 114/124] mtd: mtd_oobtest: Handle bitflips during reads Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 115/124] crypto: aes-generic - build with -Os on gcc-7+ Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 116/124] genirq/affinity: assign vectors to all possible CPUs Sasha Levin
2018-03-27 18:33 ` Thorsten Leemhuis
2018-03-30 9:58 ` Thorsten Leemhuis
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 117/124] perf tools: Fix copyfile_offset update of output offset Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 118/124] signal/parisc: Document a conflict with SI_USER with SIGFPE Sasha Levin
2018-03-20 15:20 ` Eric W. Biederman
2018-03-21 18:18 ` Sasha Levin
2018-03-21 19:49 ` Eric W. Biederman
2018-03-21 19:58 ` Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 119/124] signal/metag: " Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 120/124] signal/powerpc: Document conflicts with SI_USER and SIGFPE and SIGTRAP Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 121/124] signal/arm: Document conflicts with SI_USER and SIGFPE Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 122/124] xfs: account finobt blocks properly in perag reservation Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 123/124] tcmu: release blocks for partially setup cmds Sasha Levin
2018-03-19 15:49 ` [PATCH AUTOSEL for 4.15 124/124] thermal: int3400_thermal: fix error handling in int3400_thermal_probe() Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180403032740.GL7561@sasha-vm \
--to=alexander.levin@microsoft.com \
--cc=david@lechnology.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).