usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Jerry Zhang]

Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
released memory"
should be added to linux-4.4.y (it's already in 4.9 and 4.14).

Thanks,
Jerry

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Jerry Zhang]

Can you add linux-3.18.y to that as well? thanks

On Mon, Apr 2, 2018 at 12:12 PM Jerry Zhang <zhangjerry@google.com> wrote:

> Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> released memory"
> should be added to linux-4.4.y (it's already in 4.9 and 4.14).

> Thanks,
> Jerry

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Greg Kroah-Hartman]

On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> released memory"
> should be added to linux-4.4.y (it's already in 4.9 and 4.14).

The reason it was not included in there, or 3.18.y, is that it breaks
the build :(

Can you provide a working backport?  If so, I will be glad to apply it.

thanks,

greg k-h

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Greg Kroah-Hartman]

On Tue, Apr 03, 2018 at 11:44:53AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> > Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> > released memory"
> > should be added to linux-4.4.y (it's already in 4.9 and 4.14).
> 
> The reason it was not included in there, or 3.18.y, is that it breaks
> the build :(
> 
> Can you provide a working backport?  If so, I will be glad to apply it.

Ok, I think I got it working for 4.4.y, it took 5 different patches to
be backported first :(

thanks,

greg k-h

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Greg Kroah-Hartman]

On Tue, Apr 03, 2018 at 11:52:59AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 03, 2018 at 11:44:53AM +0200, Greg Kroah-Hartman wrote:
> > On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> > > Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> > > released memory"
> > > should be added to linux-4.4.y (it's already in 4.9 and 4.14).
> > 
> > The reason it was not included in there, or 3.18.y, is that it breaks
> > the build :(
> > 
> > Can you provide a working backport?  If so, I will be glad to apply it.
> 
> Ok, I think I got it working for 4.4.y, it took 5 different patches to
> be backported first :(

I've applied the 5 other patches to 3.18.y and had to hand-fix-up the
original request for 3.18.y.  Please verify I got it all correct.

thanks,

greg k-h

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Jerry Zhang]

> On Tue, Apr 03, 2018 at 11:52:59AM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Apr 03, 2018 at 11:44:53AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> > > > Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> > > > released memory"
> > > > should be added to linux-4.4.y (it's already in 4.9 and 4.14).
> > >
> > > The reason it was not included in there, or 3.18.y, is that it breaks
> > > the build :(
> > >
> > > Can you provide a working backport?  If so, I will be glad to apply
it.
> >
> > Ok, I think I got it working for 4.4.y, it took 5 different patches to
> > be backported first :(

> I've applied the 5 other patches to 3.18.y and had to hand-fix-up the
> original request for 3.18.y.  Please verify I got it all correct.

Nice, thanks! I'm not sure where to find those 3.18.y patches to look over
though, they don't seem to be in the stable or any of your trees.


> thanks,

> greg k-h

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Greg Kroah-Hartman]

On Tue, Apr 03, 2018 at 06:02:00PM +0000, Jerry Zhang wrote:
> > On Tue, Apr 03, 2018 at 11:52:59AM +0200, Greg Kroah-Hartman wrote:
> > > On Tue, Apr 03, 2018 at 11:44:53AM +0200, Greg Kroah-Hartman wrote:
> > > > On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> > > > > Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent accessing
> > > > > released memory"
> > > > > should be added to linux-4.4.y (it's already in 4.9 and 4.14).
> > > >
> > > > The reason it was not included in there, or 3.18.y, is that it breaks
> > > > the build :(
> > > >
> > > > Can you provide a working backport?  If so, I will be glad to apply
> it.
> > >
> > > Ok, I think I got it working for 4.4.y, it took 5 different patches to
> > > be backported first :(
> 
> > I've applied the 5 other patches to 3.18.y and had to hand-fix-up the
> > original request for 3.18.y.  Please verify I got it all correct.
> 
> Nice, thanks! I'm not sure where to find those 3.18.y patches to look over
> though, they don't seem to be in the stable or any of your trees.

They are in the stable-queue repo, the same place the automated email
that you got for when this patch was applied mentioned.  Sorry I didn't
 cc: you on all of them, my fault.

thanks,

greg k-h

Re: usb: gadget: f_hid: pick "Prevent accessing released memory" to 4.4.y

[Jerry Zhang]

Looks good to me. I also booted a 3.18 device with the patches and verified
usb works.

On Tue, Apr 3, 2018 at 11:09 AM Greg Kroah-Hartman <
gregkh@linuxfoundation.org> wrote:

> On Tue, Apr 03, 2018 at 06:02:00PM +0000, Jerry Zhang wrote:
> > > On Tue, Apr 03, 2018 at 11:52:59AM +0200, Greg Kroah-Hartman wrote:
> > > > On Tue, Apr 03, 2018 at 11:44:53AM +0200, Greg Kroah-Hartman wrote:
> > > > > On Mon, Apr 02, 2018 at 07:12:57PM +0000, Jerry Zhang wrote:
> > > > > > Commit aa65d11aa008f4de "usb: gadget: f_hid: fix: Prevent
accessing
> > > > > > released memory"
> > > > > > should be added to linux-4.4.y (it's already in 4.9 and 4.14).
> > > > >
> > > > > The reason it was not included in there, or 3.18.y, is that it
breaks
> > > > > the build :(
> > > > >
> > > > > Can you provide a working backport?  If so, I will be glad to
apply
> > it.
> > > >
> > > > Ok, I think I got it working for 4.4.y, it took 5 different patches
to
> > > > be backported first :(
> >
> > > I've applied the 5 other patches to 3.18.y and had to hand-fix-up the
> > > original request for 3.18.y.  Please verify I got it all correct.
> >
> > Nice, thanks! I'm not sure where to find those 3.18.y patches to look
over
> > though, they don't seem to be in the stable or any of your trees.

> They are in the stable-queue repo, the same place the automated email
> that you got for when this patch was applied mentioned.  Sorry I didn't
>   cc: you on all of them, my fault.

> thanks,

> greg k-h