From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:40904 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432AbeDCPI0 (ORCPT ); Tue, 3 Apr 2018 11:08:26 -0400 Date: Tue, 3 Apr 2018 17:08:25 +0200 From: Greg Kroah-Hartman To: Nathan Chancellor Cc: stable@vger.kernel.org Subject: Re: Clang warning fixes for 4.4 and 4.9 Message-ID: <20180403150825.GA16862@kroah.com> References: <20180401104446.GA5516@flashbox> <20180403102826.GC17259@kroah.com> <20180403124634.GB13077@flashbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180403124634.GB13077@flashbox> Sender: stable-owner@vger.kernel.org List-ID: On Tue, Apr 03, 2018 at 05:46:34AM -0700, Nathan Chancellor wrote: > On Tue, Apr 03, 2018 at 12:28:26PM +0200, Greg Kroah-Hartman wrote: > > On Sun, Apr 01, 2018 at 03:44:46AM -0700, Nathan Chancellor wrote: > > > db0a6fb5d97a ("audit: add tty field to LOGIN event") > > > > This feels like a new feature, not a clang build warning fix, right? > > Why is it needed? > > > > thanks, > > > > greg k-h > > It very well might but it does fix the following Clang warning: > > ../kernel/audit.c:1894:59: warning: address of array > 'tsk->signal->tty->name' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (tsk->signal && tsk->signal->tty && tsk->signal->tty->name) > ~~ ~~~~~~~~~~~~~~~~~~^~~~ > 1 warning generated. > > I guess a 4.4 only fix would be to remove the '&& tsk->signal->tty->name' > but I know you have said many times that just taking the patch in > Linus' tree is preferred. In looking at this closer, it does fix an audit problem in 4.4 for correctly handling things, and it's really tiny, so I've now queued it up, thanks. greg k-h