From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bart.vanassche@wdc.com>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>,
Douglas Gilbert <dgilbert@interlog.com>,
Damien Le Moal <damien.lemoal@wdc.com>,
Christoph Hellwig <hch@lst.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] Fix DID_OK handling in __scsi_error_from_host_byte()
Date: Thu, 5 Apr 2018 10:48:52 +0200 [thread overview]
Message-ID: <20180405084852.GA2286@lst.de> (raw)
In-Reply-To: <20180404175355.15982-1-bart.vanassche@wdc.com>
On Wed, Apr 04, 2018 at 10:53:55AM -0700, Bart Van Assche wrote:
> + /*
> + * Also check the other bytes than the status byte in result
> + * to handle the case when a SCSI LLD sets result to
> + * DRIVER_SENSE << 24 without setting SAM_STAT_CHECK_CONDITION.
> + */
> + return scsi_status_is_good(result) && (result & ~0xff) == 0 ?
> + BLK_STS_OK : BLK_STS_IOERR;
How about an readable version of the statement above?
if (scsi_status_is_good(result) && (result & ~0xff))
return BLK_STS_OK;
return BLK_STS_IOERR;
prev parent reply other threads:[~2018-04-05 8:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-04 17:53 [PATCH v2] Fix DID_OK handling in __scsi_error_from_host_byte() Bart Van Assche
2018-04-04 18:35 ` Douglas Gilbert
2018-04-04 19:54 ` Lee Duncan
2018-04-05 2:28 ` Damien Le Moal
2018-04-05 6:43 ` Hannes Reinecke
2018-04-05 8:50 ` Christoph Hellwig
2018-04-05 8:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405084852.GA2286@lst.de \
--to=hch@lst.de \
--cc=bart.vanassche@wdc.com \
--cc=damien.lemoal@wdc.com \
--cc=dgilbert@interlog.com \
--cc=hare@suse.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).