From: Christoph Hellwig <hch@lst.de>
To: "Bryant G. Ly" <bryantly@linux.vnet.ibm.com>
Cc: hch@lst.de, nab@linux-iscsi.org, martin.petersen@oracle.com,
seroyer@linux.vnet.ibm.com, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-block@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] target: Fix Fortify_panic kernel exception
Date: Fri, 13 Apr 2018 18:44:52 +0200 [thread overview]
Message-ID: <20180413164452.GA22904@lst.de> (raw)
In-Reply-To: <1523566722-24667-1-git-send-email-bryantly@linux.vnet.ibm.com>
The patch looks fine, but in general I think descriptions of what
you fixed in the code or more important than starting out with
a backtrace.
E.g. please explain what was wrong, how you fixed it and only after
that mention how it was caught. (preferably without the whole trace)
next prev parent reply other threads:[~2018-04-13 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 20:58 [PATCH] target: Fix Fortify_panic kernel exception Bryant G. Ly
2018-04-13 16:44 ` Christoph Hellwig [this message]
2018-04-17 15:18 ` Bryant G. Ly
2018-04-17 15:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180413164452.GA22904@lst.de \
--to=hch@lst.de \
--cc=bryantly@linux.vnet.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nab@linux-iscsi.org \
--cc=seroyer@linux.vnet.ibm.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).