From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sasha Levin To: Pavel Machek CC: Linus Torvalds , Steven Rostedt , Petr Mladek , "stable@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "akpm@linux-foundation.org" , "linux-mm@kvack.org" , Cong Wang , Dave Hansen , Johannes Weiner , Mel Gorman , Michal Hocko , Vlastimil Babka , Peter Zijlstra , Jan Kara , Mathieu Desnoyers , Tetsuo Handa , Byungchul Park , Tejun Heo Subject: Re: [PATCH AUTOSEL for 4.14 015/161] printk: Add console owner and waiter logic to load balance console writes Date: Mon, 16 Apr 2018 16:39:20 +0000 Message-ID: <20180416163917.GE2341@sasha-vm> References: <20180409001936.162706-15-alexander.levin@microsoft.com> <20180409082246.34hgp3ymkfqke3a4@pathway.suse.cz> <20180415144248.GP2341@sasha-vm> <20180416093058.6edca0bb@gandalf.local.home> <20180416153031.GA5039@amd> <20180416155031.GX2341@sasha-vm> <20180416160608.GA7071@amd> <20180416161412.GZ2341@sasha-vm> <20180416162850.GA7553@amd> In-Reply-To: <20180416162850.GA7553@amd> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <72CFA7D0500218408DD130DE38BEB7B7@namprd21.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: owner-linux-mm@kvack.org List-ID: On Mon, Apr 16, 2018 at 06:28:50PM +0200, Pavel Machek wrote: > >> >> Is there a reason not to take LED fixes if they fix a bug and don't >> >> cause a regression? Sure, we can draw some arbitrary line, maybe >> >> designate some subsystems that are more "important" than others, but >> >> what's the point? >> > >> >There's a tradeoff. >> > >> >You want to fix serious bugs in stable, and you really don't want >> >regressions in stable. And ... stable not having 1000s of patches >> >would be nice, too. >> >> I don't think we should use a number cap here, but rather look at the >> regression rate: how many patches broke something? >> >> Since the rate we're seeing now with AUTOSEL is similar to what we were >> seeing before AUTOSEL, what's the problem it's causing? > >Regression rate should not be the only criteria. > >More patches mean bigger chance customer's patches will have a >conflict with something in -stable, for example. Out of tree patches can't be a consideration here. There are no guarantees for out of tree code, ever.