From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50421 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753144AbeDRHRa (ORCPT ); Wed, 18 Apr 2018 03:17:30 -0400 Date: Wed, 18 Apr 2018 17:17:24 +1000 From: "Tobin C. Harding" To: Thomas Richter Cc: jeyu@kernel.org, torvalds@linux-foundation.org, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, schwidefsky@de.ibm.com, brueckner@linux.vnet.ibm.com, heiko.carstens@de.ibm.com, peterz@infradead.org, acme@kernel.org, keescook@chromium.org, stable@vger.kernel.org Subject: Re: [PATCH v3] module: Fix display of wrong module .text address Message-ID: <20180418071724.GA6892@eros> References: <20180418071436.21392-1-tmricht@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180418071436.21392-1-tmricht@linux.ibm.com> Sender: stable-owner@vger.kernel.org List-ID: On Wed, Apr 18, 2018 at 09:14:36AM +0200, Thomas Richter wrote: > Reading file /proc/modules shows the correct address: > [root@s35lp76 ~]# cat /proc/modules | egrep '^qeth_l2' > qeth_l2 94208 1 - Live 0x000003ff80401000 > > and reading file /sys/module/qeth_l2/sections/.text > [root@s35lp76 ~]# cat /sys/module/qeth_l2/sections/.text > 0x0000000018ea8363 > displays a random address. > > This breaks the perf tool which uses this address on s390 > to calculate start of .text section in memory. > > Fix this by printing the correct (unhashed) address. > > Thanks to Jessica Yu for helping on this. > > Fixes: ef0010a30935 ("vsprintf: don't use 'restricted_pointer()' when not restricting") > Cc: # v4.15+ > Suggested-by: Linus Torvalds > Signed-off-by: Thomas Richter > Cc: Jessica Yu > --- What's changed in each version please? thanks, Tobin.