From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de ([213.95.11.211]:35872 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbeDSJNa (ORCPT ); Thu, 19 Apr 2018 05:13:30 -0400 Date: Thu, 19 Apr 2018 11:14:17 +0200 From: "hch@lst.de" To: Bart Van Assche Cc: "hch@lst.de" , "shaun@tancheff.com" , "hare@suse.com" , "linux-block@vger.kernel.org" , Damien Le Moal , "martin.petersen@oracle.com" , "axboe@kernel.dk" , "stable@vger.kernel.org" Subject: Re: [PATCH] block: Avoid executing a report or reset zones while a queue is frozen Message-ID: <20180419091417.GA22988@lst.de> References: <20180417010034.28676-1-bart.vanassche@wdc.com> <20180417151857.GA25646@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: stable-owner@vger.kernel.org List-ID: On Tue, Apr 17, 2018 at 05:35:07PM +0000, Bart Van Assche wrote: > > Hmm. I think we need to avoid clearing that data and update it using > > RCU instead. Calling blk_queue_enter before submitting bios is > > something that would make zone reporting very different from any > > other block layer user. > > Hello Christoph, > > Please have a look at generic_make_request(). I think that function shows > that blk_queue_enter() is called anyway before .make_request_fn() is called. Yes, that is the point. We already call blk_queue_enter in generic_make_request, which the zone report and reset ops pass through.