From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: stable@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 4.16.y] swiotlb: fix unexpected swiotlb_alloc_coherent failures
Date: Fri, 20 Apr 2018 16:13:14 +0200 [thread overview]
Message-ID: <20180420141314.GA24101@kroah.com> (raw)
In-Reply-To: <20180419061909.3297-1-tiwai@suse.de>
On Thu, Apr 19, 2018 at 08:19:09AM +0200, Takashi Iwai wrote:
> commit 9e7f06c8beee304ee21b791653fefcd713f48b9a upstream.
>
> The code refactoring by commit 0176adb00406 ("swiotlb: refactor coherent
> buffer allocation") made swiotlb_alloc_buffer almost always failing due
> to a thinko: namely, the function evaluates the dma_coherent_ok call
> incorrectly and dealing as if it's invalid. This ends up with weird
> errors like iwlwifi probe failure or amdgpu screen flickering.
>
> This patch corrects the logic error.
>
> Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1088658
> Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1088902
> Fixes: 0176adb00406 ("swiotlb: refactor coherent buffer allocation")
> Cc: <stable@vger.kernel.org> # v4.16+
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
>
> Greg, this is a commit that felt out in the previous round due to
> cherry-pick error. Resent with a context fix.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2018-04-20 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 6:19 [PATCH 4.16.y] swiotlb: fix unexpected swiotlb_alloc_coherent failures Takashi Iwai
2018-04-20 14:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420141314.GA24101@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).