From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f195.google.com ([209.85.213.195]:33212 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbeDTTAJ (ORCPT ); Fri, 20 Apr 2018 15:00:09 -0400 Received: by mail-yb0-f195.google.com with SMTP id y5-v6so3372324ybg.0 for ; Fri, 20 Apr 2018 12:00:09 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Cc: Sean Paul , Rob Herring , Maxime Ripard , Archit Taneja , Andrzej Hajda , Laurent Pinchart , stable@vger.kernel.org, David Airlie , linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: vga-dac: Fix edid memory leak Date: Fri, 20 Apr 2018 14:59:59 -0400 Message-Id: <20180420190007.1572-1-seanpaul@chromium.org> Sender: stable-owner@vger.kernel.org List-ID: edid should be freed once it's finished being used. Fixes: 56fe8b6f4991 ("drm/bridge: Add RGB to VGA bridge support") Cc: Rob Herring Cc: Sean Paul Cc: Maxime Ripard Cc: Archit Taneja Cc: Andrzej Hajda Cc: Laurent Pinchart Cc: # v4.9+ Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index 498d5948d1a8..9837c8d69e69 100644 --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c @@ -56,7 +56,9 @@ static int dumb_vga_get_modes(struct drm_connector *connector) } drm_mode_connector_update_edid_property(connector, edid); - return drm_add_edid_modes(connector, edid); + ret = drm_add_edid_modes(connector, edid); + kfree(edid); + return ret; fallback: /* -- Sean Paul, Software Engineer, Google / Chromium OS