stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Harsh Shandilya <harsh@prjkt.io>
Cc: stable@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH v3 3.18.y 3/3] ext4: don't allow r/w mounts if metadata blocks overlap the superblock
Date: Sun, 22 Apr 2018 09:29:46 +0200	[thread overview]
Message-ID: <20180422072946.GA17290@kroah.com> (raw)
In-Reply-To: <20180422042407.5820-4-harsh@prjkt.io>

On Sun, Apr 22, 2018 at 09:54:07AM +0530, Harsh Shandilya wrote:
> From: Theodore Ts'o <tytso@mit.edu>
> 
> Commit 18db4b4e6fc31eda838dd1c1296d67dbcb3dc957 upstream.
> 
> If some metadata block, such as an allocation bitmap, overlaps the
> superblock, it's very likely that if the file system is mounted
> read/write, the results will not be pretty.  So disallow r/w mounts
> for file systems corrupted in this particular way.
> 
> Backport notes:
> 3.18.y is missing bc98a42c1f7d ("VFS: Convert sb->s_flags & MS_RDONLY to sb_rdonly(sb)")
> and e462ec50cb5f ("VFS: Differentiate mount flags (MS_*) from internal superblock flags")
> so we simply use the sb MS_RDONLY check from pre bc98a42c1f7d in place of the sb_rdonly
> function used in the upstream variant of the patch.

I've also applied this to 4.9.y and 4.4.y as it is relevant there.

thanks for all of these, all now queued up!

greg k-h

      reply	other threads:[~2018-04-22  7:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-22  4:24 [PATCH v3 3.18.y 0/3] 4.17-rc1 stable tagged ext4 patches Harsh Shandilya
2018-04-22  4:24 ` [PATCH v3 3.18.y 1/3] ext4: add validity checks for bitmap block numbers Harsh Shandilya
2018-04-22  4:24 ` [PATCH v3 3.18.y 2/3] ext4: fail ext4_iget for root directory if unallocated Harsh Shandilya
2018-04-22  4:24 ` [PATCH v3 3.18.y 3/3] ext4: don't allow r/w mounts if metadata blocks overlap the superblock Harsh Shandilya
2018-04-22  7:29   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180422072946.GA17290@kroah.com \
    --to=greg@kroah.com \
    --cc=harsh@prjkt.io \
    --cc=stable@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).