From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.linuxfoundation.org ([140.211.169.12]:47126 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755428AbeDWOND (ORCPT ); Mon, 23 Apr 2018 10:13:03 -0400 Date: Mon, 23 Apr 2018 16:12:56 +0200 From: Greg KH To: web_czom@yeah.net Cc: stable@vger.kernel.org Subject: Re: [PATCH] net/core/skbuff.c fix skb_expand_head off logic error! Message-ID: <20180423141256.GC25829@kroah.com> References: <201804231302.w3ND2kqq046079@local.dzw.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201804231302.w3ND2kqq046079@local.dzw.io> Sender: stable-owner@vger.kernel.org List-ID: On Mon, Apr 23, 2018 at 09:02:46PM +0800, web_czom@yeah.net wrote: > fix logic error! > > --- linux/net/core/skbuff.c.orig 2018-04-23 20:55:37.747731000 +0800 > +++ linux/net/core/skbuff.c 2018-04-23 20:56:30.782520000 +0800 > @@ -1492,7 +1492,7 @@ int pskb_expand_head(struct sk_buff *skb > } else { > skb_free_head(skb); > } > - off = (data + nhead) - skb->head; > + off = (skb->data - skb->head) + nhead; > > skb->head = data; > skb->head_frag = 0; This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.