From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com ([134.134.136.126]:53658 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755172AbeDZNg1 (ORCPT ); Thu, 26 Apr 2018 09:36:27 -0400 Date: Thu, 26 Apr 2018 16:36:23 +0300 From: Mika Westerberg To: Greg KH Cc: stable@vger.kernel.org, Hans de Goede , Andy Shevchenko , Linus Walleij , Benjamin Tissoires Subject: Re: Revert f5a26acf0162 ("pinctrl: intel: Initialize GPIO properly when used through irqchip") from stable trees Message-ID: <20180426133623.GI2173@lahna.fi.intel.com> References: <20180426125302.GF2173@lahna.fi.intel.com> <20180426132427.GA20051@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180426132427.GA20051@kroah.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, Apr 26, 2018 at 03:24:27PM +0200, Greg KH wrote: > On Thu, Apr 26, 2018 at 03:53:02PM +0300, Mika Westerberg wrote: > > Hi, > > > > It seems that commit f5a26acf0162 ("pinctrl: intel: Initialize GPIO > > properly when used through irqchip") can cause problems on some Skylake > > systems with Sunrisepoint PCH-H. Namely on certain systems it may turn > > the backlight PWM pin from native mode to GPIO which makes the screen > > blank during boot. > > > > There is more information here: > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1543769 > > > > The actual reason is that GPIO numbering used in BIOS is using "Windows" > > numbers meaning that they don't match the hardware 1:1 and because of > > this a wrong pin (backlight PWM) is picked and switched to GPIO mode. > > > > There is a proper fix for this but since it has quite many dependencies > > on commits that cannot be considered stable material, I suggest we > > revert commit f5a26acf0162 from stable trees 4.9, 4.14 and 4.15 to > > prevent the backlight issue. > > What is the "proper fix"? Is it in Linus's tree yet? This patch https://patchwork.ozlabs.org/patch/892813/ However, it is not yet in Linus' tree.