From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-wr0-f196.google.com ([209.85.128.196]:46812 "EHLO
        mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757153AbeD0Hf1 (ORCPT
        <rfc822;stable@vger.kernel.org>); Fri, 27 Apr 2018 03:35:27 -0400
Received: by mail-wr0-f196.google.com with SMTP id d1-v6so760814wrj.13
        for <stable@vger.kernel.org>; Fri, 27 Apr 2018 00:35:27 -0700 (PDT)
Date: Fri, 27 Apr 2018 00:35:31 -0700
From: Nathan Chancellor <natechancellor@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Sasha Levin <Alexander.Levin@microsoft.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Timur Tabi <timur@codeaurora.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [GIT PULL] commits for Linux 4.4
Message-ID: <20180427073531.GA535@flashbox>
References: <DM5PR2101MB103281E91AA711CA2CA2CBD7FB8D0@DM5PR2101MB1032.namprd21.prod.outlook.com>
 <20180427045025.GA4226@flashbox>
 <20180427070521.GA4931@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180427070521.GA4931@kroah.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, Apr 27, 2018 at 09:05:21AM +0200, Greg KH wrote:
> On Thu, Apr 26, 2018 at 09:50:25PM -0700, Nathan Chancellor wrote:
> > On Fri, Apr 27, 2018 at 02:01:20AM +0000, Sasha Levin wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA512
> > > 
> > > Hi Greg,
> > > 
> > > Pleae pull commits for Linux 4.4 .
> > > 
> > > I've sent a review request for all commits over a week ago and all
> > > comments were addressed.
> > > 
> > > 
> > > Thanks,
> > > Sasha
> > > 
> > 
> > For what it's worth, commit 87a00850c711 ("pinctrl: msm: Use dynamic
> > GPIO numbering") completely breaks touchscreen input on my Pixel 2 XL.
> 
> That's not good.  Have you reported this to the gpio developers and
> authors of that patch?
> 

I have not although I've gone ahead and CC'd them on this email.

> > I'm happy to carry the revert in my tree given it is probably a correct
> > change in mainline but I figured I would let you guys know so you can
> > make that decision.
> 
> Ah, do you think this is a userspace issue with your device and not a
> kernel problem?  That implies that this patch isn't ok and should be
> reverted upstream.
> 

I don't think this is a userspace regression. My guess is certain 
out of tree drivers expect a static base value, based on the wording
of the commit message. Unfortunately, his is all a little bit over
my head at the moment. I will try to study up on it tomorrow. I just
wanted to report the regression as soon as I uncovered it (I'd be
lying if I said I liked reporting bugs heh).

Thanks!
Nathan