From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.99]:41044 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751303AbeD1EmC (ORCPT <rfc822;stable@vger.kernel.org>);
        Sat, 28 Apr 2018 00:42:02 -0400
Date: Sat, 28 Apr 2018 06:41:52 +0200
From: Greg KH <gregkh@linuxfoundation.org>
To: Eddie Chapman <eddie@ehuk.net>
Cc: Thomas Deutschmann <whissi@gentoo.org>, stable@vger.kernel.org,
        davem@davemloft.net, nicolas.dichtel@6wind.com,
        netdev@vger.kernel.org
Subject: Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu
 unconditionally
Message-ID: <20180428044152.GD27835@kroah.com>
References: <e17c6be6-bc26-810e-0760-fc23d0206d1d@gentoo.org>
 <40404f68-8328-8ed2-15bf-9de38830f796@gentoo.org>
 <20180427135125.GA31860@kroah.com>
 <20180427144536.GA9512@kroah.com>
 <ae1401af-a400-f6de-658e-bae0b29c52e4@ehuk.net>
 <f663a39c-25f4-0558-21e0-a25c21287384@gentoo.org>
 <7485fe73-0c33-e5b4-6c9b-c8c7a359be4a@ehuk.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7485fe73-0c33-e5b4-6c9b-c8c7a359be4a@ehuk.net>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Fri, Apr 27, 2018 at 07:43:52PM +0100, Eddie Chapman wrote:
> On 27/04/18 19:07, Thomas Deutschmann wrote:
> > Hi Greg,
> > 
> > first, we need to cherry-pick another patch first:
> > >  From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 2001
> > > From: Xin Long <lucien.xin@gmail.com>
> > > Date: Mon, 25 Dec 2017 14:43:58 +0800
> > > Subject: [PATCH] geneve: update skb dst pmtu on tx path
> > > 
> > > Commit a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path") has fixed
> > > a performance issue caused by the change of lower dev's mtu for vxlan.
> > > 
> > > The same thing needs to be done for geneve as well.
> > > 
> > > Note that geneve cannot adjust it's mtu according to lower dev's mtu
> > > when creating it. The performance is very low later when netperfing
> > > over it without fixing the mtu manually. This patch could also avoid
> > > this issue.
> > > 
> > > Signed-off-by: Xin Long <lucien.xin@gmail.com>
> > > Signed-off-by: David S. Miller <davem@davemloft.net>
> 
> Oops, I completely missed that the coreos patch doesn't have the geneve hunk
> that is in the original 4.15 patch. I don't load the geneve module on my box
> hence why no problems surfaced on my machine.
> 
> Thanks Thomas for the correct instructions. Ignore my message Greg, I'll
> drop back into the shadows where I belong, sorry for the noise!

Talking about patches and pointing me at them is not noise at all, don't
be sorry! :)

I'll work on this after these next kernels are released, thanks all for
the details on what needs to be done.

greg k-h