From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bin Liu <b-liu@ti.com>
Cc: linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: musb: host: fix potential NULL pointer dereference
Date: Mon, 30 Apr 2018 09:42:15 -0700 [thread overview]
Message-ID: <20180430164215.GA17510@kroah.com> (raw)
In-Reply-To: <1525105254-2852-2-git-send-email-b-liu@ti.com>
On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> musb_start_urb() doesn't check the pass-in parameter if it is NULL. But
> in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> returned from first_qh(), which could be NULL.
>
> So wrap the musb_start_urb() call here with a if condition check to
> avoid the potential NULL pointer dereference.
>
> Fixes: f283862f3b5cb("usb: musb: NAK timeout scheme on bulk TX endpoint")
Nit, you forgot a ' ', this should be:
f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
You also had one extra id value in there, odd. I'll edit this by
hand...
greg k-h
next prev parent reply other threads:[~2018-04-30 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 16:20 [PATCH 0/2] musb fixes for v4.17-rc4 Bin Liu
2018-04-30 16:20 ` [PATCH 1/2] usb: musb: host: fix potential NULL pointer dereference Bin Liu
2018-04-30 16:42 ` Greg Kroah-Hartman [this message]
2018-04-30 18:11 ` Bin Liu
2018-04-30 18:24 ` Greg Kroah-Hartman
2018-04-30 18:41 ` Bin Liu
2018-04-30 16:20 ` [PATCH 2/2] usb: musb: trace: fix NULL pointer dereference in musb_g_tx() Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430164215.GA17510@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=b-liu@ti.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).