stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] perf session: Fix undeclared 'oe'
@ 2018-04-11 18:41 Murilo Opsfelder Araujo
  2018-04-11 19:33 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 7+ messages in thread
From: Murilo Opsfelder Araujo @ 2018-04-11 18:41 UTC (permalink / raw)
  To: linux-kernel
  Cc: Murilo Opsfelder Araujo, stable, Alexander Shishkin, Andi Kleen,
	Arnaldo Carvalho de Melo, David Carrillo-Cisneros,
	Greg Kroah-Hartman, He Kuang, Ingo Molnar, Jiri Olsa,
	Masami Hiramatsu, Paul Mackerras, Paul Turner, Peter Zijlstra,
	Sasha Levin, Simon Que, Stephane Eranian, Wang Nan

Using linux-3.18.y branch, perf build fails with the following:

    $ make -s -j16 -C tools/perf V=1 WERROR=0 NO_LIBUNWIND=1 HAVE_CPLUS_DEMANGLE=1 NO_GTK2=1 NO_LIBNUMA=1 NO_STRLCPY=1 NO_BIONIC=1 prefix=/usr DESTDIR=/tmp/builddir/build all
    [...]
    util/session.c: In function ‘__perf_session__process_pipe_events’:
    util/session.c:1093:36: error: ‘oe’ undeclared (first use in this function)
      ordered_events__set_copy_on_queue(oe, true);
                                        ^
    util/session.c:1093:36: note: each undeclared identifier is reported only once for each function it appears in

This patch fixes it for linux-3.18.y branch.

Fixes: 95b33b99cdd6 ("perf inject: Copy events when reordering events in pipe mode")
Cc: <stable@vger.kernel.org> # 3.18.x
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: David Carrillo-Cisneros <davidcc@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: He Kuang <hekuang@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Paul Turner <pjt@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sasha Levin <alexander.levin@microsoft.com>
Cc: Simon Que <sque@chromium.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Wang Nan <wangnan0@huawei.com>
Signed-off-by: Murilo Opsfelder Araujo <muriloo@linux.ibm.com>
---
 tools/perf/util/session.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index dc3d3b1b813e..c2d4a7ec40df 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -1073,6 +1073,7 @@ volatile int session_done;
 static int __perf_session__process_pipe_events(struct perf_session *session,
 					       struct perf_tool *tool)
 {
+	struct ordered_events *oe = &session->ordered_events;
 	int fd = perf_data_file__fd(session->file);
 	union perf_event *event;
 	uint32_t size, cur_size = 0;
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-30 18:42 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-11 18:41 [PATCH] perf session: Fix undeclared 'oe' Murilo Opsfelder Araujo
2018-04-11 19:33 ` Greg Kroah-Hartman
2018-04-11 20:21   ` Murilo Opsfelder Araújo
2018-04-30 17:11     ` Murilo Opsfelder Araujo
2018-04-30 17:20       ` Greg Kroah-Hartman
2018-04-30 17:49         ` Greg Kroah-Hartman
2018-04-30 18:41           ` Murilo Opsfelder Araujo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).