From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from lelnx194.ext.ti.com ([198.47.27.80]:9424 "EHLO
        lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752732AbeD3Sls (ORCPT
        <rfc822;stable@vger.kernel.org>); Mon, 30 Apr 2018 14:41:48 -0400
Date: Mon, 30 Apr 2018 13:41:47 -0500
From: Bin Liu <b-liu@ti.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: <linux-usb@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH 1/2] usb: musb: host: fix potential NULL pointer
 dereference
Message-ID: <20180430184147.GC21238@uda0271908>
References: <1525105254-2852-1-git-send-email-b-liu@ti.com>
 <1525105254-2852-2-git-send-email-b-liu@ti.com>
 <20180430164215.GA17510@kroah.com>
 <20180430181134.GB21238@uda0271908>
 <20180430182448.GA21778@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20180430182448.GA21778@kroah.com>
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Mon, Apr 30, 2018 at 11:24:48AM -0700, Greg Kroah-Hartman wrote:
> On Mon, Apr 30, 2018 at 01:11:34PM -0500, Bin Liu wrote:
> > On Mon, Apr 30, 2018 at 09:42:15AM -0700, Greg Kroah-Hartman wrote:
> > > On Mon, Apr 30, 2018 at 11:20:53AM -0500, Bin Liu wrote:
> > > > musb_start_urb() doesn't check the pass-in parameter if it is NULL.  But
> > > > in musb_bulk_nak_timeout() the parameter passed to musb_start_urb() is
> > > > returned from first_qh(), which could be NULL.
> > > > 
> > > > So wrap the musb_start_urb() call here with a if condition check to
> > > > avoid the potential NULL pointer dereference.
> > > > 
> > > > Fixes: f283862f3b5cb("usb: musb: NAK timeout scheme on bulk TX endpoint")
> > > 
> > > Nit, you forgot a ' ', this should be:
> > > 	f283862f3b5c ("usb: musb: NAK timeout scheme on bulk TX endpoint")
> > 
> > Sorry, thanks.
> > 
> > > You also had one extra id value in there, odd.  I'll edit this by
> > 
> > Not sure why 'git blame' gives that one extra on my computer. I will see
> > if I will figure it out...
> 
> Why use 'git blame'?  I use:
> 	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"
> 
> to generate these types of lines.

My ~/.gitconfig already has
	abbrev = 12

but I used 'git blame' to find the commit id which introduces the bug,
then just directly copied the commit id from there... only until now
know 'git blame' gives 13 chars...

I will create a shortcut for the command you gave above to avoid this 13
chars problem from now on.

Thanks,
-Bin.