stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Paul Menzel <pmenzel+linux-stable@molgen.mpg.de>
Cc: stable@vger.kernel.org
Subject: Re: Formatting of stable commit messages
Date: Tue, 1 May 2018 14:10:20 -0700	[thread overview]
Message-ID: <20180501211020.GA32744@kroah.com> (raw)
In-Reply-To: <20180427100344.GA12941@kroah.com>

On Fri, Apr 27, 2018 at 12:03:44PM +0200, Greg Kroah-Hartman wrote:
> On Fri, Apr 27, 2018 at 11:34:58AM +0200, Paul Menzel wrote:
> > Dear Greg,
> > 
> > 
> > Looking at the change-log of the stable series, there are two lines between
> > the commit messages summary [1] and the first line of the commit message
> > body.
> > 
> > > commit 4c8e0270dc7afb10d4e06be4adfd177db5cb3cb8
> > > Author: Tang Junhui <tang.junhui@zte.com.cn>
> > > Date:   Wed Feb 7 11:41:46 2018 -0800
> > > 
> > >     bcache: fix for data collapse after re-attaching an attached device
> > >     [ Upstream commit 73ac105be390c1de42a2f21643c9778a5e002930 ]
> > 
> > I assume you scripts generate that. Could they be changed to just add one
> > blank line?
> 
> It's my script that messes with that, sometimes, and not others.  I
> haven't really taken the time to figure it out, it's here:
> 	https://github.com/gregkh/gregkh-linux/blob/master/stable/dave_split.pl
> if you want to figure it out :)
> 
> Is this really causing a problem with anything?  It's just an "extra"
> blank line, nothing is being attributed incorrectly.

Ok, now that I see this, I can't "unsee" it, so I fixed the issue in my
script.  Shouldn't happen again.

thanks,

greg k-h

      reply	other threads:[~2018-05-01 21:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27  9:34 Formatting of stable commit messages Paul Menzel
2018-04-27  9:40 ` Willy Tarreau
2018-04-27 10:03 ` Greg Kroah-Hartman
2018-05-01 21:10   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180501211020.GA32744@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=pmenzel+linux-stable@molgen.mpg.de \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).