From: Greg KH <gregkh@linuxfoundation.org>
To: Rolf Evers-Fischer <embedded24@evers-fischer.de>
Cc: stable@vger.kernel.org, alexander.levin@microsoft.com,
andy.shevchenko@gmail.com, kishon@ti.com,
lorenzo.pieralisi@arm.com
Subject: Re: Patch "PCI: endpoint: Fix kernel panic after put_device()" has been added to the 4.16-stable tree
Date: Wed, 2 May 2018 08:58:03 -0700 [thread overview]
Message-ID: <20180502155803.GA18373@kroah.com> (raw)
In-Reply-To: <alpine.LNX.2.21.99.1805021741240.628@5HSWXM1>
On Wed, May 02, 2018 at 05:51:40PM +0200, Rolf Evers-Fischer wrote:
>
>
> On Wed, 2 May 2018, Greg KH wrote:
>
> > On Wed, May 02, 2018 at 01:18:07PM +0200, Rolf Evers-Fischer wrote:
> > > On Wed, May 2, 2018 at 00:35 AM <gregkh@linuxfoundation.org> wrote:
> > >
> > > > This is a note to let you know that I've just added the patch titled
> > >
> > > > PCI: endpoint: Fix kernel panic after put_device()
> > >
> > > > to the 4.16-stable tree which can be found at:
> > >
> > > > http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
> > >
> > > > The filename of the patch is:
> > > > pci-endpoint-fix-kernel-panic-after-put_device.patch
> > > > and it can be found in the queue-4.16 subdirectory.
> > >
> > > > If you, or anyone else, feels it should not be added to the stable tree,
> > > > please let <stable@vger.kernel.org> know about it.
> > >
> > > This patch is the 2nd one of a series of patches. If you want to add it
> > > to the stable tree without the first patch, you must add a
> > >
> > > + kfree(func_name);
> > >
> > > before returning from the function.
> > >
> > > The upstream commit of the first patch is
> > > 36cc14ac14c0d49d33820a82dab52a7edc802fef PCI: endpoint: Simplify name
> > > allocation for EPF device
> >
> > Thanks for letting me know, I'll just drop this patch as without the
> > first one, this isn't needed and isn't an issue, right?
> >
> > thanks,
> >
> > greg k-h
> >
>
> It is still an issue (even without the first one!), but it will only occur
> on PCI endpoints when setting the devicename or adding the device fails.
> Therefore I think you can drop this patch for the stable series.
Thanks for confirming this.
greg k-h
prev parent reply other threads:[~2018-05-02 15:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 11:18 Patch "PCI: endpoint: Fix kernel panic after put_device()" has been added to the 4.16-stable tree Rolf Evers-Fischer
2018-05-02 15:38 ` Greg KH
2018-05-02 15:51 ` Rolf Evers-Fischer
2018-05-02 15:58 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502155803.GA18373@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexander.levin@microsoft.com \
--cc=andy.shevchenko@gmail.com \
--cc=embedded24@evers-fischer.de \
--cc=kishon@ti.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).