From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com ([62.4.15.54]:47673 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933773AbeEIHvA (ORCPT ); Wed, 9 May 2018 03:51:00 -0400 Date: Wed, 9 May 2018 09:50:57 +0200 From: Boris Brezillon To: David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Eric Anholt , stable@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats Message-ID: <20180509095057.09f7d9a1@bbrezillon> In-Reply-To: <20180507121303.5610-1-boris.brezillon@bootlin.com> References: <20180507121303.5610-1-boris.brezillon@bootlin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org List-ID: On Mon, 7 May 2018 14:13:03 +0200 Boris Brezillon wrote: > When using uni-planar formats (like RGB), the scaling parameters are > stored in plane 0, not plane 1. > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > Cc: stable@vger.kernel.org > Signed-off-by: Boris Brezillon Queued to drm-misc-fixes. > --- > drivers/gpu/drm/vc4/vc4_plane.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c > index ebf081c7a53b..6831975604b5 100644 > --- a/drivers/gpu/drm/vc4/vc4_plane.c > +++ b/drivers/gpu/drm/vc4/vc4_plane.c > @@ -541,7 +541,7 @@ static int vc4_plane_mode_set(struct drm_plane *plane, > * the scl fields here. > */ > if (num_planes == 1) { > - scl0 = vc4_get_scl_field(state, 1); > + scl0 = vc4_get_scl_field(state, 0); > scl1 = scl0; > } else { > scl0 = vc4_get_scl_field(state, 1);