From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:56312 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752011AbeENMDb (ORCPT ); Mon, 14 May 2018 08:03:31 -0400 Date: Mon, 14 May 2018 05:03:28 -0700 From: Christoph Hellwig To: Bart Van Assche Cc: Jason Gunthorpe , Doug Ledford , linux-rdma@vger.kernel.org, Steve Wise , stable@vger.kernel.org Subject: Re: [PATCH] IB/srpt: Increase port count Message-ID: <20180514120328.GA5081@infradead.org> References: <20180510223209.10277-1-bart.vanassche@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180510223209.10277-1-bart.vanassche@wdc.com> Sender: stable-owner@vger.kernel.org List-ID: On Thu, May 10, 2018 at 03:32:09PM -0700, Bart Van Assche wrote: > Since there are adapters that have four ports, increase the size of > the srpt_device.port[] array. This patch avoids that the following > warning is hit with quad port Chelsio adapters: > > WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port)); Should we add a IB_MAX_PORTS define that ULPs can rely on in the core?