From: "hch@infradead.org" <hch@infradead.org>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"dledford@redhat.com" <dledford@redhat.com>,
"swise@opengridcomputing.com" <swise@opengridcomputing.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] IB/srpt: Increase port count
Date: Mon, 14 May 2018 07:24:34 -0700 [thread overview]
Message-ID: <20180514142434.GA3233@infradead.org> (raw)
In-Reply-To: <b0540168a9b5215f8e02ea3f7e496541686a8230.camel@wdc.com>
On Mon, May 14, 2018 at 02:23:16PM +0000, Bart Van Assche wrote:
> > > WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port));
> >
> > Should we add a IB_MAX_PORTS define that ULPs can rely on in the core?
>
> How many drivers would benefit from the introduction of such a constant?
> A third possible alternative is that I change the port array in the ib_srpt
> driver such that it is allocated dynamically. That would allow to eliminate
> the WARN_ON() statement mentioned above.
No idea how many benefit. But either we have an upper limit, or
ULPs should be able to deal with any possible number, e.g. by using
your dynamic allocation idea.
prev parent reply other threads:[~2018-05-14 14:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 22:32 [PATCH] IB/srpt: Increase port count Bart Van Assche
2018-05-14 12:03 ` Christoph Hellwig
2018-05-14 14:23 ` Bart Van Assche
2018-05-14 14:24 ` hch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514142434.GA3233@infradead.org \
--to=hch@infradead.org \
--cc=Bart.VanAssche@wdc.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox