Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Tarun Vyas <tarun.vyas@intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/psr: Fix missed entry in PSR setup time table.
Date: Fri, 18 May 2018 10:45:59 -0700	[thread overview]
Message-ID: <20180518174559.GA79130@otc-chromeosbuild-5> (raw)
In-Reply-To: <20180511005419.11199-1-dhinakaran.pandiyan@intel.com>

On Thu, May 10, 2018 at 05:54:19PM -0700, Dhinakaran Pandiyan wrote:
> Entry corresponding to 220 us setup time was missing. I am not aware of
> any specific bug this fixes, but this could potentially result in enabling
> PSR on a panel with a higher setup time requirement than supported by the
> hardware.
> 
> I verified the value is present in eDP spec versions 1.3, 1.4 and 1.4a.
> 
> Fixes: 6608804b3d7f ("drm/dp: Add drm_dp_psr_setup_time()")
> Cc: stable@vger.kernel.org
> Cc: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> Cc: Jose Roberto de Souza <jose.souza@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
>  drivers/gpu/drm/drm_dp_helper.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 36c7609a4bd5..a7ba602a43a8 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -1159,6 +1159,7 @@ int drm_dp_psr_setup_time(const u8 psr_cap[EDP_PSR_RECEIVER_CAP_SIZE])
>  	static const u16 psr_setup_time_us[] = {
>  		PSR_SETUP_TIME(330),
>  		PSR_SETUP_TIME(275),
> +		PSR_SETUP_TIME(220),
Verified the PSR set up time table in the eDP 1.4b spec
Reviewed-by: Tarun Vyas <tarun.vyas@intel.com>
>  		PSR_SETUP_TIME(165),
>  		PSR_SETUP_TIME(110),
>  		PSR_SETUP_TIME(55),
> -- 
> 2.14.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2018-05-18 17:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-11  0:54 [PATCH] drm/psr: Fix missed entry in PSR setup time table Dhinakaran Pandiyan
2018-05-11 18:03 ` Souza, Jose
2018-05-11 19:46   ` Dhinakaran Pandiyan
2018-05-18 17:45 ` Tarun Vyas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180518174559.GA79130@otc-chromeosbuild-5 \
    --to=tarun.vyas@intel.com \
    --cc=dhinakaran.pandiyan@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox