From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:44282 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752761AbeEUQji (ORCPT ); Mon, 21 May 2018 12:39:38 -0400 Date: Mon, 21 May 2018 17:39:33 +0100 From: James Hogan To: Mathias Kresin Cc: john@phrozen.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, martin.blumenstingl@googlemail.com, hauke@hauke-m.de, stable@vger.kernel.org Subject: Re: [PATCH] MIPS: lantiq: gphy: Drop reboot/remove reset asserts Message-ID: <20180521163932.GA12779@jamesdev> References: <1523176203-18926-1-git-send-email-dev@kresin.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <1523176203-18926-1-git-send-email-dev@kresin.me> Sender: stable-owner@vger.kernel.org List-ID: --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Apr 08, 2018 at 10:30:03AM +0200, Mathias Kresin wrote: > While doing a global software reset, these bits are not cleared and let > some bootloader fail to initialise the GPHYs. The bootloader don't > expect the GPHYs in reset, as they aren't during power on. >=20 > The asserts were a workaround for a wrong syscon-reboot mask. With a > mask set which includes the GPHY resets, these resets aren't required > any more. >=20 > Fixes: 126534141b45 ("MIPS: lantiq: Add a GPHY driver which uses the RCU = syscon-mfd") > Cc: stable@vger.kernel.org # 4.14+ > Signed-off-by: Mathias Kresin Applied for 4.17. Thanks for the acks/reviews folk! Thanks James --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQS7lRNBWUYtqfDOVL41zuSGKxAj8gUCWwL2PgAKCRA1zuSGKxAj 8rK8AP0SVYNW7NEA13xPomDmbyz2GyrZgOSsEOtpLYO1Q9nJfQD/TP6iEOWkftpf ZVv9xJSbsuXgiteRcmpW1dId20KZVwc= =Z5bm -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--