Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Juergen Gross <jgross@suse.com>
Cc: stable@vger.kernel.org, xen-devel@lists.xenproject.org,
	David Woodhouse <dwmw@amazon.co.uk>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen: fix pv domain on amd in 4.9 stable branch
Date: Wed, 30 May 2018 10:33:36 +0200	[thread overview]
Message-ID: <20180530083336.GC9685@kroah.com> (raw)
In-Reply-To: <20180529131136.15624-1-jgross@suse.com>

On Tue, May 29, 2018 at 03:11:36PM +0200, Juergen Gross wrote:
> Commit 944e0fc51a89c9827b98813d65dc083274777c7f ("x86/amd: don't set
> X86_BUG_SYSRET_SS_ATTRS when running under Xen") breaks Xen pv-domains
> on AMD processors, as a prerequisite patch from upstream wasn't added
> to 4.9.

What is the prerequsite patch's git id in Linus's tree?

> Fix that by adding the prerequisite setting of X86_FEATURE_XENPV to the
> Xen pv early boot path.
> 
> Cc: David Woodhouse <dwmw@amazon.co.uk>
> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
>  arch/x86/xen/enlighten.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
> index 081437b5f381..674656cdb68c 100644
> --- a/arch/x86/xen/enlighten.c
> +++ b/arch/x86/xen/enlighten.c
> @@ -1632,6 +1632,9 @@ asmlinkage __visible void __init xen_start_kernel(void)
>  	xen_init_irq_ops();
>  	xen_init_cpuid_mask();
>  
> +	/* Needed for init_amd(). */
> +	setup_force_cpu_cap(X86_FEATURE_XENPV);
> +
>  #ifdef CONFIG_X86_LOCAL_APIC
>  	/*
>  	 * set up the basic apic ops.
> -- 
> 2.13.6

I'd prefer to take whatever is in Linus's tree if at all possible.

thanks,

greg k-h

  reply	other threads:[~2018-05-30  8:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-29 13:11 [PATCH] xen: fix pv domain on amd in 4.9 stable branch Juergen Gross
2018-05-30  8:33 ` Greg KH [this message]
2018-05-30  9:33   ` Juergen Gross
2018-05-30  9:46     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180530083336.GC9685@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=boris.ostrovsky@oracle.com \
    --cc=dwmw@amazon.co.uk \
    --cc=jgross@suse.com \
    --cc=stable@vger.kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox